Skip to content

Additional GHA bugs #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gregorydlogan merged 4 commits into from
Jul 13, 2026
+6 −38
Merged

Additional GHA bugs #1712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3453eb3
Adding token, and making built artifacts unique per run
gregorydlogan Jul 7, 2026
643744f
Setting the PR number so that the comment making step can find it.
gregorydlogan Jul 7, 2026
c2253de
In some cases, like my test infra, the owner here needs to be templated.
gregorydlogan Jul 7, 2026
daef5d9
Removing developer/committer check prior to building PR.
gregorydlogan Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 1 addition & 35 deletions .github/workflows/pr-build-test-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,44 +67,10 @@ jobs:
- name: Upload build to GHA
uses: actions/upload-artifact@v4
with:
name: build
name: ${{ github.run_id }}
path: ${{ runner.temp }}/build.tar


#This is currently defunct, but kept around in case we run into issues in the future
# where this check might be handy, cf spammers filing PRs or something.
# Previously we checked is_team_member prior to doing anything else above
check-member:
name: Check organization membership
if: github.repository_owner == 'opencast'
runs-on: ubuntu-latest

# Map a step output to a job output
outputs:
is_team_member: ${{ steps.is_developer.outputs.permitted == 'true' || steps.is_committer.outputs.permitted == 'true' }}

steps:
- name: Check if user is Opencast developer
id: is_developer
if: ${{ github.event.pull_request.head.repo.full_name != 'opencast/editor' }}
uses: TheModdingInquisition/actions-team-membership@v1.0
with:
team: developers
# Personal Access Token with the `read:org` permission
token: ${{ secrets.ORGANIZATION_MEMBER_SECRET }}
exit: false

- name: Check if user is Opencast committer
id: is_committer
if: ${{ github.event.pull_request.head.repo.full_name != 'opencast/editor' }}
uses: TheModdingInquisition/actions-team-membership@v1.0
with:
team: committers
# Personal Access Token with the `read:org` permission
token: ${{ secrets.ORGANIZATION_MEMBER_SECRET }}
exit: false


check-no-modified-translations:
name: Translations only via Crowdin
if: github.repository_owner == 'opencast'
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/pr-deploy-test-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@ jobs:
- name: Fetch build from GHA
uses: actions/download-artifact@v4
with:
name: build
path: ${{ runner.temp }}/build.tar
name: ${{ github.event.workflow_run.id }}
path: ${{ runner.temp }}/
github-token: ${{ github.token }}
run-id: ${{ github.event.workflow_run.id }}

- name: Store build in the clone
Expand Down Expand Up @@ -83,6 +84,7 @@ jobs:
- name: Add comment with deployment location
uses: thollander/actions-comment-pull-request@v3
with:
pr-number: ${{ github.event.workflow_run.pull_requests[0].number }}
comment-tag: static-test-deployment
message: >
This pull request is deployed at
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-remove-test-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:

- name: Clone test repository
run: |
git clone -b gh-pages "git@github.com:opencast/editor-test.git" editor-test
git clone -b gh-pages "git@github.com:${{ github.repository_owner }}/editor-test.git" editor-test

- name: Delete build if present
working-directory: editor-test
Expand Down
Loading