Additional GHA bugs#1712
Merged
Merged
Conversation
gregorydlogan
added
type:bug
This would, in theory, prevent spam attacks from filling up the test repository, but in practice does nothing. GH by default requires manual enabling of builds from not-previously-contributing accounts, and if you *have* developer/committer access and your account gets compromised then... well there's not much we can do.
Member
Author
|
Note that this check was failing, and was removed by daef5d9, which is doubly funny since a malicious contributor would probably remove that step as part of an attack anyway |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a number of issues related to #1709
Notably, this PR: