Skip to content

Css color consistency#1431

Open
Arnei wants to merge 13 commits intoopencast:developfrom
Arnei:css-color-consistency
Open

Css color consistency#1431
Arnei wants to merge 13 commits intoopencast:developfrom
Arnei:css-color-consistency

Conversation

@Arnei
Copy link
Member

@Arnei Arnei commented Sep 8, 2025

Includes #1400. #1400 Should be reviewed and merged first.

This PR replaces the "hardcoded" color values that are flying around everywhere in our scss files with the color variables defined in _variables.scss. Color values that are not represented by our variables are either added to the variables file, or replaced with a variable with a similar value.

Goals:

  • Make colors easier to work with. Having our colors all grouped in one place should make it easier to e.g. implement a dark mode.
  • Reduce the number of different colors. We really should not need 50 different shades of grey (number approximated).
  • Increase contrast. I used the opportunity to slightly change some colors to make the ui more readable.

How to test this

This touches every element that has color, so unfortunately pretty much everything. Quickly click through everything ui element you can find and check if any colors appear "off".

Arnei added 11 commits August 15, 2025 13:47
Make more dropdowns have the same background and text color
for hovered options.
Make the published cell in the events table look like other cells with
similar appearance.
In the table heeader, fix both sorting chevrons being colored
as "active", instead of only one.
Also make the active chevron darker to be more easily
recognizable.
@Arnei Arnei added type:code-enhancement Internal improvements to the codebase type:visual-clarity Improves UI readability labels Sep 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1431

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1431

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei Arnei force-pushed the css-color-consistency branch from 166c3cc to ea1a238 Compare December 1, 2025 13:20
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

This pull request is deployed at test.admin-interface.opencast.org/1431/2025-12-01_13-20-35/ .
It might take a few minutes for it to become available.

@ferishili ferishili assigned ferishili and unassigned ferishili Feb 23, 2026
@ferishili ferishili self-requested a review February 23, 2026 13:36
Copy link
Contributor

@ferishili ferishili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arnei,
Your changes look fine, however a few things need your attention!

First and most important one is:
While running the UI click-through tests, I noticed the contrast in the calendar (month and year selection) looks off, as shown below. Could you please take a look at that as well?

Image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed there's a whole block of code commented out. Is that intentional?
If so, could you please add a short comment above it explaining why it's being kept? Also, it would be better to use a proper block comment instead of multiple single-line comments for readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:code-enhancement Internal improvements to the codebase type:visual-clarity Improves UI readability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants