Conversation
Make more dropdowns have the same background and text color for hovered options.
Make the published cell in the events table look like other cells with similar appearance.
In the table heeader, fix both sorting chevrons being colored as "active", instead of only one. Also make the active chevron darker to be more easily recognizable.
|
This pull request has conflicts ☹ |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request has conflicts ☹ |
166c3cc to
ea1a238
Compare
|
This pull request is deployed at test.admin-interface.opencast.org/1431/2025-12-01_13-20-35/ . |
ferishili
left a comment
There was a problem hiding this comment.
Thanks @Arnei,
Your changes look fine, however a few things need your attention!
First and most important one is:
While running the UI click-through tests, I noticed the contrast in the calendar (month and year selection) looks off, as shown below. Could you please take a look at that as well?
There was a problem hiding this comment.
I noticed there's a whole block of code commented out. Is that intentional?
If so, could you please add a short comment above it explaining why it's being kept? Also, it would be better to use a proper block comment instead of multiple single-line comments for readability.
Includes #1400. #1400 Should be reviewed and merged first.
This PR replaces the "hardcoded" color values that are flying around everywhere in our scss files with the color variables defined in
_variables.scss. Color values that are not represented by our variables are either added to the variables file, or replaced with a variable with a similar value.Goals:
How to test this
This touches every element that has color, so unfortunately pretty much everything. Quickly click through everything ui element you can find and check if any colors appear "off".