[Repo Assist] eng: add src/Directory.Build.props with analyzer and NuGet audit settings - #211
Closed
github-actions[bot] wants to merge 1 commit into
Conversation
…ings Adds a Directory.Build.props for OpenClaw.Shared, OpenClaw.Tray.WinUI, and OpenClaw.Cli that aligns them with the quality baseline already present in OpenClaw.CommandPalette/Directory.Build.props. Changes: - EnableNETAnalyzers=true: explicit (already the SDK default for .NET 5+) - AnalysisMode=Recommended: enables the Recommended rule set (superset of Default), matching CommandPalette's existing setting - NuGetAuditMode=all: audit direct AND transitive packages for known CVEs during restore (default is 'direct') OpenClaw.CommandPalette is NOT affected — MSBuild stops at its own Directory.Build.props one directory level deeper and does not walk up to this file. Test status: 652 passed, 20 skipped (unchanged from baseline). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
automation
enhancement
12 tasks
Collaborator
|
Superseded by #219, which carries this Directory.Build.props analyzer/audit baseline in a human-reviewed branch. |
shanselman
deleted the
repo-assist/eng-src-directory-build-props-2026-04-25-5f0e668784ef2e01
branch
April 27, 2026 03:04
codemonkeychris
pushed a commit
to codemonkeychris/openclaw-windows-node
that referenced
this pull request
Apr 27, 2026
Add src/Directory.Build.props to align source projects on the recommended analyzer baseline and transitive NuGet vulnerability auditing. Also allow .NET SDK feature-band roll-forward so the repo can build with installed 10.0.2xx SDKs while retaining the 10.0.100 baseline. Supersedes openclaw#211 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist.
Adds
src/Directory.Build.propsto giveOpenClaw.Shared,OpenClaw.Tray.WinUI, andOpenClaw.Clia consistent quality baseline that already exists inOpenClaw.CommandPalette/Directory.Build.props.What changed
New file:
src/Directory.Build.propsEnableNETAnalyzerstrueAnalysisModeRecommendedDefault— catches common bugs, anti-patterns, and style issues. Matches the CommandPalette project's existing setting.NuGetAuditModealldirectonly).What's NOT affected
OpenClaw.CommandPalettehas its ownDirectory.Build.propsone directory level deeper (src/OpenClaw.CommandPalette/Directory.Build.props). MSBuild stops walking up when it finds the nearestDirectory.Build.props, so this file does not apply to CommandPalette at all — CommandPalette already has its own equivalent settings.Trade-offs
AnalysisMode=Recommendedmay surface new warnings (not errors) in the Tray app build (WinUI) and future code. Source projects don't haveTreatWarningsAsErrors, so CI will not break. Any new warnings will be visible and actionable.NuGetAuditMode=allmay produce restore-time warnings if a transitive dependency has a known CVE. This is intentional — surfacing the issue is the point.Test Status
dotnet test OpenClaw.Shared.Tests— 652 passed, 20 skipped (unchanged from baseline)dotnet test OpenClaw.Tray.Tests— not runnable in this environment (WinUI); no src changes, no expected impact./build.ps1— not runnable on Linux; no logic changes to source files