[Repo Assist] fix(security): stop leaking ex.Message in CanvasCapability and BrowserProxyCapability

src/OpenClaw.Shared/Capabilities/BrowserProxyCapability.cs

@@ -80,19 +80,23 @@ public override async Task<NodeInvokeResponse> ExecuteAsync(NodeInvokeRequest re
         }
         catch (HttpRequestException ex)
         {
-            return Error($"Browser control host is not reachable on 127.0.0.1:{controlPort}: {ex.Message}. {BuildReachabilityGuidance(controlPort, _sshRemoteGatewayPort)}");
+            Logger.Warn($"browser proxy: control host unreachable on 127.0.0.1:{controlPort}: {ex.Message}");
+            return Error($"Browser control host is not reachable on 127.0.0.1:{controlPort}. {BuildReachabilityGuidance(controlPort, _sshRemoteGatewayPort)}");
         }
         catch (JsonException ex)
         {
-            return Error($"Browser control host returned invalid JSON: {ex.Message}");
+            Logger.Warn($"browser proxy: control host returned invalid JSON: {ex.Message}");
+            return Error("Browser control host returned invalid JSON");
         }
         catch (IOException ex)
         {
-            return Error($"Browser proxy file read failed: {ex.Message}");
+            Logger.Warn($"browser proxy: file read failed: {ex.Message}");
+            return Error("Browser proxy file read failed");
         }
         catch (UnauthorizedAccessException ex)
         {
-            return Error($"Browser proxy file read denied: {ex.Message}");
+            Logger.Warn($"browser proxy: file read denied: {ex.Message}");
+            return Error("Browser proxy file read denied");
         }
     }
 

src/OpenClaw.Shared/Capabilities/CanvasCapability.cs

@@ -216,8 +216,8 @@ private async Task<NodeInvokeResponse> HandleNavigateAsync(NodeInvokeRequest req
         }
         catch (Exception ex)
         {
-            Logger.Error($"canvas.navigate handler failed: {ex.Message}", ex);
-            return Error($"Navigate failed: {ex.Message}");
+            Logger.Error("canvas.navigate handler failed", ex);
+            return Error("Navigate failed");
         }
     }
 
@@ -246,7 +246,8 @@ private async Task<NodeInvokeResponse> HandleEvalAsync(NodeInvokeRequest request
         }
         catch (Exception ex)
         {
-            return Error($"Eval failed: {ex.Message}");
+            Logger.Error("canvas.eval handler failed", ex);
+            return Error("Eval failed");
         }
     }
 
@@ -277,7 +278,8 @@ private async Task<NodeInvokeResponse> HandleSnapshotAsync(NodeInvokeRequest req
         }
         catch (Exception ex)
         {
-            return Error($"Snapshot failed: {ex.Message}");
+            Logger.Error("canvas.snapshot handler failed", ex);
+            return Error("Snapshot failed");
         }
     }
 
@@ -367,7 +369,7 @@ private string ReadValidatedJsonlPath(string jsonlPath, string command)
         }
         catch (Exception ex)
         {
-            throw new InvalidOperationException($"Invalid jsonlPath: {ex.Message}", ex);
+            throw new InvalidOperationException("Invalid jsonlPath", ex);
         }
 
         if (!IsPathWithinRoot(fullPath, tempRoot))
@@ -497,7 +499,8 @@ private async Task<NodeInvokeResponse> HandleA2UIDumpAsync()
         }
         catch (Exception ex)
         {
-            return Error($"CANVAS_DUMP_FAILED: {ex.Message}");
+            Logger.Error("canvas.a2ui.dump handler failed", ex);
+            return Error("CANVAS_DUMP_FAILED");
         }
     }
 
@@ -523,7 +526,8 @@ private async Task<NodeInvokeResponse> HandleCapsAsync()
         }
         catch (Exception ex)
         {
-            return Error($"CANVAS_CAPS_FAILED: {ex.Message}");
+            Logger.Error("canvas.a2ui.caps handler failed", ex);
+            return Error("CANVAS_CAPS_FAILED");
         }
     }
 }

tests/OpenClaw.Shared.Tests/CapabilityTests.cs

@@ -1372,7 +1372,8 @@ public async Task Navigate_HandlerThrows_SurfacesAsError()
         };
         var res = await cap.ExecuteAsync(req);
         Assert.False(res.Ok);
-        Assert.Contains("browser refused", res.Error);
+        Assert.Contains("Navigate failed", res.Error);
+        Assert.DoesNotContain("browser refused", res.Error);
     }
 
     [Fact]
@@ -1389,7 +1390,8 @@ public async Task Eval_ReturnsError_WhenHandlerThrows()
         };
         var res = await cap.ExecuteAsync(req);
         Assert.False(res.Ok);
-        Assert.Contains("WebView2 not ready", res.Error);
+        Assert.Contains("Eval failed", res.Error);
+        Assert.DoesNotContain("WebView2 not ready", res.Error);
     }
 
     [Fact]
@@ -1426,7 +1428,8 @@ public async Task Snapshot_ReturnsError_WhenHandlerThrows()
         var req = new NodeInvokeRequest { Id = "c15", Command = "canvas.snapshot", Args = Parse("""{}""") };
         var res = await cap.ExecuteAsync(req);
         Assert.False(res.Ok);
-        Assert.Contains("Canvas not visible", res.Error);
+        Assert.Contains("Snapshot failed", res.Error);
+        Assert.DoesNotContain("Canvas not visible", res.Error);
     }
 
     [Fact]
@@ -1541,7 +1544,7 @@ public async Task A2UIDump_ReturnsError_WhenHandlerThrows()
         var res = await cap.ExecuteAsync(req);
         Assert.False(res.Ok);
         Assert.Contains("CANVAS_DUMP_FAILED", res.Error);
-        Assert.Contains("dispatcher gone", res.Error);
+        Assert.DoesNotContain("dispatcher gone", res.Error);
     }
 
     [Fact]