[Repo Assist] test(shared): add DeepLinkParser unit tests - #456
Merged
shanselman merged 1 commit intoMay 21, 2026
Merged
Conversation
DeepLinkParser had no test coverage despite being pure testable logic (no I/O, no Windows dependencies). This adds 27 tests covering: - ParseDeepLink: null/whitespace/wrong-scheme → null - ParseDeepLink: path extraction (with/without trailing slash) - ParseDeepLink: Windows-canonicalized form (slash before query) - ParseDeepLink: single and multi-parameter extraction - ParseDeepLink: case-insensitive parameter lookup - ParseDeepLink: URL-encoded value decoding - ParseDeepLink: empty query → empty Parameters dict - GetQueryParam: null/empty query or empty key → null - GetQueryParam: value retrieval, case-insensitivity, URL decoding Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
30 tasks
shanselman
marked this pull request as ready for review
May 21, 2026 20:34
shanselman
deleted the
repo-assist/improve-deeplink-parser-tests-15ed34c432b39e5d
branch
May 21, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
DeepLinkParserhad no test coverage despite being pure, testable logic (no I/O, no Windows dependencies). This adds 27 tests covering the full public API.What's tested
ParseDeepLink— null/whitespace/wrong schemenullParseDeepLink— path extractionParseDeepLink— Windows-canonicalized formopenclaw://send/?text=hello→ path"send"ParseDeepLink— query string and parametersParseDeepLink— parameter lookupParseDeepLink— URL decoding%20→ space,%2B→+GetQueryParam— null/empty inputsnullGetQueryParam— value retrievalTest Status
Full suite: 1796 passed, 7 pre-existing failures (Windows-path tests on Linux CI), 28 skipped — same baseline as before this PR.