Skip to content

[Repo Assist] eng(build): enforce TreatWarningsAsErrors across all source projects #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

[Repo Assist] eng(build): enforce TreatWarningsAsErrors across all source projects #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
<!-- Audit all package dependencies (direct + transitive) for known CVEs during restore.
Defaults to "direct" in the SDK; "all" provides broader security coverage. -->
<NuGetAuditMode>all</NuGetAuditMode>

<!-- Treat compiler warnings as errors across all source projects.
Keeps the warning count at zero and prevents silent warning accumulation
that is later expensive to clean up. Individual projects may suppress a
specific warning via <NoWarn> only when the warning is intentional and
the suppression is documented. -->
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>

</Project>
6 changes: 6 additions & 0 deletions src/OpenClaw.Shared/OpenClaw.Shared.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<RootNamespace>OpenClaw.Shared</RootNamespace>
<!-- CS8524: switch expression on an enum without a _ arm — intentional in
ExecApprovalsCoordinator so the compiler flags any new enum member that
is added without a corresponding case. The remaining int-cast space
(e.g. (ExecApprovalPromptOutcome)4) is an acceptable gap given that all
callers produce only named values. -->
<NoWarn>$(NoWarn);CS8524</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down