Skip to content

[Repo Assist] test(connection): add missing DeriveOverall edge-case coverage #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanselman merged 1 commit into from
Jun 7, 2026
Merged

[Repo Assist] test(connection): add missing DeriveOverall edge-case coverage #595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions tests/OpenClaw.Connection.Tests/ConnectionStateMachineTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,16 @@ public void Reset_ReturnsToIdle()
[InlineData(RoleConnectionState.Connected, RoleConnectionState.Connecting, true, OverallConnectionState.Connecting)]
[InlineData(RoleConnectionState.Connected, RoleConnectionState.Idle, false, OverallConnectionState.Ready)]
[InlineData(RoleConnectionState.Idle, RoleConnectionState.Idle, true, OverallConnectionState.Idle)]
// Node errors are suppressed when node mode is disabled → Ready (not Degraded).
[InlineData(RoleConnectionState.Connected, RoleConnectionState.Error, false, OverallConnectionState.Ready)]
[InlineData(RoleConnectionState.Connected, RoleConnectionState.PairingRejected, false, OverallConnectionState.Ready)]
[InlineData(RoleConnectionState.Connected, RoleConnectionState.RateLimited, false, OverallConnectionState.Ready)]
// Node connecting is ignored when node mode is disabled → Ready (not Connecting).
[InlineData(RoleConnectionState.Connected, RoleConnectionState.Connecting, false, OverallConnectionState.Ready)]
// Operator connected, node idle, node enabled → operator-only connected (fallthrough).
[InlineData(RoleConnectionState.Connected, RoleConnectionState.Idle, true, OverallConnectionState.Connected)]
// Node PairingRequired is reported regardless of nodeEnabled.
[InlineData(RoleConnectionState.Connected, RoleConnectionState.PairingRequired, false, OverallConnectionState.PairingRequired)]
public void DeriveOverall_ReturnsCorrectState(
RoleConnectionState op, RoleConnectionState node, bool nodeEnabled, OverallConnectionState expected)
{
Expand Down