Validate MXC SDK 0.7.0 on Windows build 26200.8728 - #786
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 25, 2026, 2:58 PM ET / 18:58 UTC. Summary Reproducibility: not applicable. as a bug reproduction; this is a PR changing MXC runtime policy. The contributor supplied Windows 26200.8737 validation and direct MXC/runtime proof for the changed behavior. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Have maintainers explicitly accept the MXC fallback/security policy and merge only after exact-head platform checks are green; use #787 for the full Gateway E2E proof layer. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction; this is a PR changing MXC runtime policy. The contributor supplied Windows 26200.8737 validation and direct MXC/runtime proof for the changed behavior. Is this the best way to solve the issue? Unclear from product-policy perspective: the implementation path is coherent and covered by focused tests, but maintainers still need to accept the compatibility-default versus stricter sandbox policy. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 7a7f39df2397. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Update after addressing the ClawSweeper P1:
Proof run on Windows build 26200.8728:
Windows Sandbox note:
|
|
@clawsweeper re-review Update after the ClawSweeper review and scoped autoreview follow-up:
Proof from the final local pass on Windows build 26200.8728:
Autoreview initially found two implementation issues after applying the compatibility-default policy: a stale InfoBar state for strict+toggle-off, and host-shell approval semantics in strict unavailable mode. Both were fixed before the final clean rerun. Commit pushed: |
|
🦞🧹 I asked ClawSweeper to review this item again. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddba6f8628
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@clawsweeper re-review PR body was updated after the |
|
Status update after latest push (ca99562):
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@clawsweeper re-review Status update for rebased PR2 head
Fresh validation on Windows
Scope note:
|
|
🦞🧹 I asked ClawSweeper to review this item again. |
Tracking issue: #784
Base includes: #785, #822
Followed by: #787
Stack note: PR1 #785 and the separate
build.ps1Windows host-detection fix #822 are now both inmain. This PR is rebased on the currentmainbaseline and carries only the PR2 MXC SDK/runtime-policy slice. Full Gateway installed-app proof remains in the follow-up PR #787.Summary
This PR updates the Windows MXC dependency and runtime policy for the current MXC 0.7 path:
@microsoft/mxc-sdkfrom0.6.1to0.7.0.26200.8728+.26300.8289+.isolation_sessionseparately gated to26300.8553+, matching SDK0.7.0documentation/source.0.7.0-alphafor SDK0.7.0.TEMP,TMP,TMPDIR, andPATHinside the launched shell because non-empty MXCprocess.envis not usable on this backend.SystemRunBlockHostFallbackWhenMxcUnavailable=trueas the strict opt-in mode that blocks/fails closed when MXC is unavailable.system.runenvironment variables before any sandbox-unavailable host fallback while sandboxing is enabled.cmd; normal uncontained host fallback still resolves through the host runner.shell="pwsh"to an absolutepwsh.exepath before launching with an empty MXC process environment.0.7.0, build/UBR gates, config generation, fallback compatibility, strict blocking, diagnostics, shell resolution, policy grants, and installer MXC SDK restore assertions.Why
The local validation machine is Windows Release Preview 25H2 build
26200.8737. MXC SDK0.7.0can run the processcontainer/AppContainer-DACL path there, but the older OpenClaw availability gate rejected this family because it only allowed the26300line.This PR keeps the gate explicit and narrow. It does not add a broad
>= 26200rule and does not enableisolation_sessionon26200.Behavior Contract
This PR intentionally separates behavior by containment boundary:
SystemRunBlockHostFallbackWhenMxcUnavailable=true: block/fail closed.The stricter security work in this PR is inside that compatibility contract: fallback shell approval alignment, unsupported-shell fail-closed behavior, no custom sandbox env before fallback, filtered readonly grants, and explicit UI diagnostics.
Validation
Final local validation for PR2 head
442de02aon Windows build26200.8737:.\build.ps1passed without setting$env:OS.dotnet test tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --filter "FullyQualifiedName~MxcCommandRunnerTests|FullyQualifiedName~MxcConfigBuilderTests|FullyQualifiedName~MxcPolicyBuilderTests|FullyQualifiedName~SystemRunTests" --logger "trx;LogFileName=Shared.pr2-pr3-current-26200-8737.trx"passed:141passed,0failed,0skipped.dotnet test tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --filter "FullyQualifiedName~SettingsRoundTripTests|FullyQualifiedName~InstallerIssAssertionTests" --logger "trx;LogFileName=Tray.pr2-current-26200-8737.trx"passed:28passed,0failed,0skipped.Remaining Publication Limits
Notes
The separate
build.ps1Windows host-detection issue was fixed upstream in #822 and is now part of the currentmainbaseline. This PR is rebased on that baseline but does not include the #822 code.