Fix Win10 native chat icon fallback - #796
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 21, 2026, 4:57 PM ET / 20:57 UTC. Summary Reproducibility: yes. with high confidence from source and reporter evidence: the related Windows 10/v0.6.3 screenshots match current-main native chat code that hardcodes Review metrics: 3 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land this fallback repair, or an equivalent one, after Windows 10 native chat proof shows icons rendering without a manual font install, AGENTS-required validation is complete, and the regression guard covers any Do we have a high-confidence way to reproduce the issue? Yes, with high confidence from source and reporter evidence: the related Windows 10/v0.6.3 screenshots match current-main native chat code that hardcodes Is this the best way to solve the issue? Yes directionally: using Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 5d1c65bb6ff8. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Co-authored-by: shanselman <2892+shanselman@users.noreply.github.com>
Extend the Windows 10 icon font fallback fix to setup UI glyphs and tighten the guard test so it skips build artifacts while catching fully qualified FontFamily hardcodes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Assert that rendered A2UI icons use the SymbolThemeFontFamily resource so the UI test matches the Windows 10 fallback behavior introduced by this PR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Windows 10 native chat view rendered composer/action icons as missing-glyph boxes because some controls hard-coded
Segoe Fluent Icons, which is not reliably available there.Icon font fallback
SymbolThemeFontFamily.Segoe MDL2 Assetson Windows 10.Regression coverage
Segoe Fluent Iconsin WinUI sources.