Fix user chat bubble text rendering - #883
Conversation
Reset reused WinUI TextBlock visual state before applying selection-safe user prompt inlines so chat bubbles render the full typed prompt instead of stale single-glyph output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Codex review: needs real behavior proof before merge. Reviewed June 28, 2026, 4:08 AM ET / 08:08 UTC. Summary Reproducibility: Do we have a high-confidence way to reproduce the issue? No: the linked issue gives the exact prompt and before screenshot, and source inspection matches the display-path failure, but this read-only review did not run the Windows tray UI. Review metrics: 1 noteworthy metric.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the focused rendering fix after a viewable current-head Windows tray screenshot or recording shows the exact user prompt rendering normally and required validation is green. Do we have a high-confidence way to reproduce the issue? Do we have a high-confidence way to reproduce the issue? No: the linked issue gives the exact prompt and before screenshot, and source inspection matches the display-path failure, but this read-only review did not run the Windows tray UI. Is this the best way to solve the issue? Is this the best way to solve the issue? Yes, based on source review: resetting reused TextBlock visual state before applying selectable inlines is a narrow fix for the reported user-bubble rendering path; the remaining blocker is proof, not a different code direction. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against d08a3e749973. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Fixes #880
Summary
TextBlockvisual state before applying selection-safe user prompt inlines.FontFamilyper dispatcher so user bubbles do not inherit stale glyph/trimming state from reused controls.ApplyPlainSelectableInlines(...).Validation
./build.ps1— passeddotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restore— passed: 2629 passed / 31 skippeddotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restore— passed: 1433 passedpython .agents/skills/autoreview/scripts/autoreview --mode commit --commit HEAD— clean: no accepted/actionable findingsReal behavior proof
yes file another bugin the user bubble instead of a single glyph/dot.get_window_state; manual screenshot proof was used instead.