Hide completed sessions by default - #924
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 5, 2026, 6:23 PM ET / 22:23 UTC. Summary Reproducibility: yes. Current-main source shows SessionsPage renders all non-cron sessions without a done/completed filter; the PR proof and tests exercise the new hidden-by-default behavior. Review metrics: 2 noteworthy metrics.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the tray-only toggle after exact-head checks finish, while keeping #881 open for ACP archive and cross-surface config follow-up. Do we have a high-confidence way to reproduce the issue? Yes. Current-main source shows SessionsPage renders all non-cron sessions without a done/completed filter; the PR proof and tests exercise the new hidden-by-default behavior. Is this the best way to solve the issue? Yes. The PR implements the narrow accepted tray-only fix with a persisted toggle and leaves ACP lifecycle/archive and global config work to the canonical follow-up issue. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against adcb4c378f90. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (5 earlier review cycles)
|
c3ebb2b to
af6517f
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
@openclaw-mantis visual task: verify the Sessions page hides clean completed sessions by default and Show completed reveals them again. |
|
@TurboTheTurtle " Current Mantis is mostly narrow QA lanes: Telegram, Discord, Slack-ish desktop smoke, browser/desktop visual capture, and generic scenario dispatch where there’s already wiring. It’s not a magic “prove any PR” bot yet. " It doesn't work in this repo yet, sorry |
af6517f to
499fd23
Compare
|
@clawsweeper re-review Maintainer decision: tray-only hidden-by-default filtering is the accepted narrow scope; #881 stays open for ACP archive/global-config follow-up. Exact-head Windows VM build, full tray tests, visible UIA, toggle persistence, and restart proof are now in the PR body. |
|
🦞🧹 I asked ClawSweeper to review this item again. |
Addresses the tray UI portion of #881. ACP lifecycle/archive semantics and a cross-surface gateway config remain separate follow-up work in that issue.
Adds a persisted Show completed toggle on the Sessions page and hides clean completed sessions by default. Failed, killed, timed-out, running, unknown, and aborted sessions stay visible. The localized toggle restores completed sessions without changing gateway state.
Maintainer review also preserves the selected channel when session data or completed visibility rebuilds the tabs; selection falls back to All only when that channel no longer has a visible session.
Validation
Validated on
499fd23ain a Windows 11 Pro ARM64 Parallels VM:build.ps1✅ Shared, CLI, WinNode CLI, SetupEngine, WinUIOpenClaw.Tray.Tests✅ 1531 passedReal behavior proof
Windows UI Automation against the built Sessions page verified:
{ "default": { "name": "Show completed", "automationId": "SessionsPageShowCompleted", "enabled": true, "offscreen": false, "state": "Off" }, "toggle": { "before": "Off", "after": "On", "persistedShowCompletedSessions": true }, "restart": { "state": "On", "persistedShowCompletedSessions": true, "offscreen": false } }Focused behavior tests cover
done/completedhidden by default; failed/killed/timeout/running/unknown/aborted sessions visible; Show completed restoring all sessions; and selected-channel preservation/fallback.