Skip to content

fix: use ISO-8601 format for share expiration dates #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zerox80 wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −4
Open

fix: use ISO-8601 format for share expiration dates #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fabe8c
fix: send share expiration date in ISO-8601 UTC format to match backend
zerox80 May 19, 2026
929d7ce
docs: add comments explaining necessity of ISO-8601 UTC format for ba…
zerox80 May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...ary/src/main/java/eu/opencloud/android/lib/resources/shares/CreateRemoteShareOperation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,9 @@ class CreateRemoteShareOperation(
}

if (expirationDateInMillis > INIT_EXPIRATION_DATE_IN_MILLIS) {
val dateFormat = SimpleDateFormat(FORMAT_EXPIRATION_DATE, Locale.getDefault())
val dateFormat = SimpleDateFormat(FORMAT_EXPIRATION_DATE, Locale.getDefault()).apply {
timeZone = java.util.TimeZone.getTimeZone("UTC")
}
val expirationDate = Calendar.getInstance()
expirationDate.timeInMillis = expirationDateInMillis
val formattedExpirationDate = dateFormat.format(expirationDate.time)
Expand Down Expand Up @@ -197,6 +199,9 @@ class CreateRemoteShareOperation(
private const val PARAM_PERMISSIONS = "permissions"

//Arguments - constant values
private const val FORMAT_EXPIRATION_DATE = "yyyy-MM-dd"
// ISO-8601 UTC format is required by the backend to correctly parse expiration dates,
// especially for private user/group share creations and updates, ensuring compatibility
// when these features are eventually exposed in the mobile UI.
private const val FORMAT_EXPIRATION_DATE = "yyyy-MM-dd'T'HH:mm:ss'Z'"
}
}
9 changes: 7 additions & 2 deletions ...ary/src/main/java/eu/opencloud/android/lib/resources/shares/UpdateRemoteShareOperation.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,9 @@ class UpdateRemoteShareOperation

} else if (expirationDateInMillis > INITIAL_EXPIRATION_DATE_IN_MILLIS) {
// set expiration date
val dateFormat = SimpleDateFormat(FORMAT_EXPIRATION_DATE, Locale.getDefault())
val dateFormat = SimpleDateFormat(FORMAT_EXPIRATION_DATE, Locale.getDefault()).apply {
timeZone = java.util.TimeZone.getTimeZone("UTC")
}
val expirationDate = Calendar.getInstance()
expirationDate.timeInMillis = expirationDateInMillis
val formattedExpirationDate = dateFormat.format(expirationDate.time)
Expand Down Expand Up @@ -216,7 +218,10 @@ class UpdateRemoteShareOperation
private const val PARAM_PERMISSIONS = "permissions"

//Arguments - constant values
private const val FORMAT_EXPIRATION_DATE = "yyyy-MM-dd"
// ISO-8601 UTC format is required by the backend to correctly parse expiration dates,
// especially for private user/group share creations and updates, ensuring compatibility
// when these features are eventually exposed in the mobile UI.
private const val FORMAT_EXPIRATION_DATE = "yyyy-MM-dd'T'HH:mm:ss'Z'"
private const val INITIAL_EXPIRATION_DATE_IN_MILLIS: Long = 0
}
}
Loading