Skip to content

schema: start error message with lowercase#760

Closed
stevvooe wants to merge 1 commit into
opencontainers:masterfrom
stevvooe:linter-fix
Closed

schema: start error message with lowercase#760
stevvooe wants to merge 1 commit into
opencontainers:masterfrom
stevvooe:linter-fix

Conversation

@stevvooe
Copy link
Copy Markdown
Contributor

Signed-off-by: Stephen Day stephen.day@getcruise.com

Signed-off-by: Stephen Day <stephen.day@getcruise.com>
@cyphar
Copy link
Copy Markdown
Member

cyphar commented Feb 19, 2019

LGTM (we should figure out what's wrong with the CI).

Approved with PullApprove

@vbatts
Copy link
Copy Markdown
Member

vbatts commented Feb 19, 2019

LGTM
Do the linters not work on go1.9 now?

Approved with PullApprove

@vbatts
Copy link
Copy Markdown
Member

vbatts commented Feb 19, 2019

lol pullapprove disapproves of me, i reckon

@stevvooe
Copy link
Copy Markdown
Contributor Author

Merging. I am going to drop Go 1.9 support in another PR. I don't want to hunt that one down.

@stevvooe
Copy link
Copy Markdown
Contributor Author

stevvooe commented Feb 19, 2019

LGTM

(Admittedly, I am tricking the system, @caniszczyk, can you see what is happening with @vbatts?)

Approved with PullApprove

@jonboulle
Copy link
Copy Markdown
Contributor

Fixed via #782

@jonboulle jonboulle closed this Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants