Skip to content

Add maintainer nomination template#919

Merged
jonjohnsonjr merged 1 commit into
opencontainers:mainfrom
nishakm:912-maintainer-template
Jul 29, 2022
Merged

Add maintainer nomination template#919
jonjohnsonjr merged 1 commit into
opencontainers:mainfrom
nishakm:912-maintainer-template

Conversation

@nishakm
Copy link
Copy Markdown
Contributor

@nishakm nishakm commented May 16, 2022

This is a PR template to propose adding new maintainers

Fixes #912

Signed-off-by: nisha nisha@ctlfsh.tech

@sajayantony
Copy link
Copy Markdown
Member

+1

Comment thread .github/PULL_REQUEST_TEMPLATE/maintainer_nomination.md Outdated
@nishakm nishakm force-pushed the 912-maintainer-template branch from 4ae7dcc to 75e5f8e Compare May 16, 2022 17:24
@sudo-bmitch
Copy link
Copy Markdown
Contributor

I'd lean towards making the Justification section contain a comment describing possible ways to nominees could have activity, rather than fixed headings. It gives flexibility to participate in different ways. Some may attend meetings, respond on the mailing list, in slack, and I think all sorts of contributions should be valuable. The key part for me is whether they'll help respond to PRs since that's the primary responsibility for being a maintainer that I see.

I think we also want to look at what other templates would be useful, but that can be separate from this PR.

Comment on lines +13 to +17
### Community Activity

### Working Group Activity

### OCI Contributions
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nishakm - want to just remove these 3 headings for now so we can get this in?

@nishakm
Copy link
Copy Markdown
Contributor Author

nishakm commented May 26, 2022

May 26 meeting: remove headings under justification and instead add comment on possible work a nominator can highlight

This is a PR template to propose adding new maintainers

Fixes opencontainers#912

Signed-off-by: nisha <nisha@ctlfsh.tech>
@nishakm nishakm force-pushed the 912-maintainer-template branch from 75e5f8e to ba3f174 Compare May 26, 2022 17:44
Copy link
Copy Markdown
Contributor

@jdolitsky jdolitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sudo-bmitch
Copy link
Copy Markdown
Contributor

@opencontainers/image-spec-maintainers PTAL

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdolitsky
Copy link
Copy Markdown
Contributor

Can we get a merge on this?

@Eldogor447-ui

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minimum criteria for new maintainers?

8 participants