checks, tests and style

[vbatts]

golint, go tests, etc.

• Set up some kind of CI (travis?)
• ensure the code conforms to golint
• enable go test ./... in CI
• enable golint in CI
• validate DCO

[vbatts]

there are no _test.go to test yet, so that doesn't make sense yet. But golint and setting up CI is good to do now.

[wking]

On Mon, Aug 03, 2015 at 07:33:11AM -0700, Vincent Batts wrote:

But golint and setting up CI is good to do now.

Yes please :).

I just noticed that 73bf1ba (JSON objects are easier to
parse/manipulate, 2015-08-27, #120) landed without a Signed-off-by
tag, despite the README requiring one by that point 1. Anyhow, if
we do decide to enforce things like this, I think we should be running
a CI service like Travis so we don't forget to check.

 Actually, the README just explains what the Signed-off-by tag
 means, but it doesn't seem to *require* contributed commits to
 contain a sign-off.  The DCO docs landed with 84707b08 (Add
 license and DCO information for contributions, 2015-07-02, #54),
 and reading through that PR it appears the intention was to
 require a sign-off.

[vbatts]

I've found where travis needed authorization for my membership in opencontainers. That's been requested now.

[vbatts]

Also, #154 got the golint squared up.

[vbatts]

Working up a DCO validator right now.

[vbatts]

Thanks @crosbymichael for enabling travis.
Now only to merge #167 and we can close out this issue too.