Skip to content

version: more explicit version for comparison #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crosbymichael merged 2 commits into from
Sep 11, 2015
Merged

version: more explicit version for comparison #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
580701c
version: more explicit version for comparison
vbatts Sep 10, 2015
d335ecd
README: releases section
vbatts Sep 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

This project is where the [Open Container Initiative](http://www.opencontainers.org/) Specifications are written.
This is a work in progress.
We should have a first draft by end of July 2015.

Table of Contents

Expand All @@ -20,6 +19,11 @@ To provide context for users the following section gives example use cases for e

- A user can create a root filesystem and configuration, with low-level OS and host specific details, and launch it as a container under an Open Container runtime.

## Releases

There is a loose [Road Map](https://github.com/opencontainers/specs/wiki/RoadMap:) on the wiki.
During the `0.x` series of OCI releases we make no backwards compatibility guarantees and intend to break the schema during this series.

# The 5 principles of Standard Containers

Define a unit of software delivery called a Standard Container.
Expand Down
13 changes: 12 additions & 1 deletion version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,15 @@
package specs

import "fmt"

const (
// VersionMajor is for an API incompatible changes
VersionMajor = 0
// VersionMinor is for functionality in a backwards-compatible manner
Copy link
Copy Markdown
Contributor

@wking wking Sep 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe “VersionMinor is for backwards-compatible API changes”? And then mirror that for VersionMajor with “VersionMajor is for backwards-incompatible API changes”.

Copy link
Copy Markdown
Member Author

@vbatts vbatts Sep 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is leaning on verbiage from SemVer

Copy link
Copy Markdown
Contributor

@wking wking Sep 10, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Thu, Sep 10, 2015 at 12:32:25PM -0700, Vincent Batts wrote:

  • // VersionMinor is for functionality in a backwards-compatible manner

this is leaning on verbiage from SemVer

Ah, consistency with semver.org is probably better than consistency
between the entries in this case. So suggestion retracted ;).

VersionMinor = 1
// VersionPatch is for backwards-compatible bug fixes
VersionPatch = 0
)

// Version is the specification version that the package types support.
const Version = "pre-draft"
var Version = fmt.Sprintf("%d.%d.%d", VersionMajor, VersionMinor, VersionPatch)