Add Parquet-Exporter helm chart#195
Conversation
charts/parquet-exporter/Chart.yaml
Outdated
| @@ -0,0 +1,24 @@ | |||
| apiVersion: v2 | |||
| name: parquet-exporter | |||
There was a problem hiding this comment.
could we make this "opencost-parquet-exporter"?
There was a problem hiding this comment.
That will have a ripple effect in the templates, but I prefer the verbosity/specificity
charts/parquet-exporter/Chart.yaml
Outdated
| @@ -0,0 +1,24 @@ | |||
| apiVersion: v2 | |||
| name: parquet-exporter | |||
There was a problem hiding this comment.
That will have a ripple effect in the templates, but I prefer the verbosity/specificity
… tag to :main, implement review comments
…sed when not empty
asdfgugus
left a comment
asdfgugus
left a comment
There was a problem hiding this comment.
I did not test it on my cluster, but the code LGTM.
mattray
left a comment
mattray
left a comment
There was a problem hiding this comment.
I think the values need to move to opencost-parquet-exporter, but I didn't test.
|
This pull request has been marked as stale because it has been open for 60 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days. |
|
This pull request has been marked as stale because it has been open for 60 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days. |
|
I will review this PR after the change to the parquet export repo is merged. |
lmello
left a comment
lmello
left a comment
There was a problem hiding this comment.
Please fix the trailling whitespaces:
Error: 1:56 [trailing-spaces] trailing spaces
Error: 8:22 [trailing-spaces] trailing spaces
Error: 12:68 [trailing-spaces] trailing spaces
Error: 27:12 [trailing-spaces] trailing spaces
Error: 59:209 [trailing-spaces] trailing spaces
Error: 62:117 [trailing-spaces] trailing spaces
|
This pull request has been marked as stale because it has been open for 60 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days. |
|
This pull request has been marked as stale because it has been open for 60 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days. |
|
@lmello Sorry, for missing this. Done |
|
Thanks @cklingspor, I will merge this. |
|
@cklingspor do you want to be the maintainer of the helm chart ? if yes you can add yourself to the maintainers on it to fix the CI error. if not, you can add my name on it. |
Sure! I've added my name. Will add way to contact later. |
5 participants
Moved from opencost/opencost-parquet-exporter#10
Hey everyone,
I've created a first draft of a helm chart for the parquet-exporter. I do not have a setup where I can use AWS as of now, therefore the actual push to a S3 bucket is not yet tested. However, I was able to install the chart and run the cronjob in my minikube.
Used helm-docs to create a rough documentation around the chart
The chart itself is relatively straight forward I think
Let me know what you think!