Add opencost.ui.useIPv6 feature flag#272
Merged
mittal-ishaan merged 2 commits intoopencost:mainfrom Apr 18, 2025
Merged
Conversation
ameijer
reviewed
Apr 17, 2025
Signed-off-by: tintii <attard.nicky@gmail.com>
mittal-ishaan
approved these changes
Apr 18, 2025
mittal-ishaan
pushed a commit
that referenced
this pull request
Apr 21, 2025
* Add opencost.ui.useIPv6 feature flag * Update Chart.yaml patch version instead of minor Signed-off-by: tintii <attard.nicky@gmail.com> * remove extra default for opencost.ui.useIPv6 feature flag, now it actually works. --------- Signed-off-by: tintii <attard.nicky@gmail.com> Co-authored-by: nicholas.attard <nicholas.attard@gamesys.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently errors are thrown when the nginx is unable to bind to an IPv6 address. This needs to be disabled for clusters where IPv6 is disabled.
I've added a flag that defaults to true for this setting so it's backwards compatibly but allows disabling the IPv6 requirement.