fix: use default sc when sc name not specified#312
Merged
mittal-ishaan merged 2 commits intoopencost:mainfrom Oct 14, 2025
Merged
fix: use default sc when sc name not specified#312mittal-ishaan merged 2 commits intoopencost:mainfrom
mittal-ishaan merged 2 commits intoopencost:mainfrom
Conversation
Member
|
Thank you @cwyl02 |
mittal-ishaan
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently pvc yaml always specify the storageClassName field in the pvc template even when storageClassName is not specified in the values.yaml.
This change makes the chart behavior more transparent to user so that the user could skip setting storageclass and let k8s api server assign the default SC to the PVC.