refactor(pdf_extract): remove hardcoded paste values in crop_img function#82
Merged
myhloli merged 1 commit intoopendatalab:xiaomeng_devfrom Aug 9, 2024
Merged
refactor(pdf_extract): remove hardcoded paste values in crop_img function#82myhloli merged 1 commit intoopendatalab:xiaomeng_devfrom
myhloli merged 1 commit intoopendatalab:xiaomeng_devfrom
Conversation
…tion The crop_img function now accepts `crop_paste_x` and `crop_paste_y` as parameters instead of using hardcoded values. This change makes the function more flexible andeasier to adjust for different use cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crop_img function now accepts
crop_paste_xandcrop_paste_yas parameters instead of using hardcoded values. This change makes the function more flexible andeasier to adjust for different use cases.