Fix Pro users seeing upgrade prompts#403
Merged
Merged
Conversation
Pro users were incorrectly seeing payment prompts because BillingManager initialization would return early when enabled=false, skipping the Pro flavor check. This left billingPreferences=null, causing hasPurchased() to return false. Moved Pro flavor handling before the enabled check to ensure Pro users always get ads removed regardless of billing manager state. Fixes user reports of "app keeps trying to force another payment" in Pro version. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Move Pro flavor detection before enabled check to ensure billingPreferences is always initialized for Pro users. This prevents null pointer issues in hasPurchased() that were causing Pro users to see upgrade prompts. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on a user review: "Terrible app! I bought the pro version, and yet the app keeps trying to force another payment."
Pro users were incorrectly seeing payment prompts because BillingManager initialization would return early when enabled=false, skipping the Pro flavor check. This left billingPreferences=null, causing hasPurchased() to return false.
Moved Pro flavor handling before the enabled check to ensure Pro users always get ads removed regardless of billing manager state.
Fixes user reports of "app keeps trying to force another payment" in Pro version.
🤖 Generated with Claude Code