Skip to content

Add common file types registration mode (fixes #374) #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 6 commits into from
Closed

Add common file types registration mode (fixes #374) #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
861b0c4
Initial plan
Copilot Jul 13, 2025
2cc1dac
Add COMMON_TYPES activity alias and update MainActivity logic
Copilot Jul 13, 2025
7062852
Improve MainActivity logic and add basic test for file type switch
Copilot Jul 13, 2025
cbfad52
Replace DOCX/PPTX/XLSX with classic Word DOC format in COMMON_TYPES
Copilot Jul 13, 2025
ac96894
Simplify to two-mode design: catch-all vs catch-supported types
Copilot Jul 13, 2025
06370ad
Remove unnecessary empty lines and revert strings.xml change
Copilot Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions app/src/androidTest/java/at/tomtasche/reader/test/MainActivityTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import android.net.Uri;
import android.util.ArrayMap;

import androidx.appcompat.widget.SwitchCompat;
import androidx.core.content.FileProvider;
import androidx.test.espresso.IdlingRegistry;
import androidx.test.espresso.IdlingResource;
Expand Down Expand Up @@ -184,4 +185,22 @@ public void testPDF() {
.perform(click());
});
}

@Test
public void testFileTypeSwitch() {
// Test the file type registration switch functionality
SwitchCompat fileTypeSwitch = mainActivityActivityTestRule.getActivity().findViewById(R.id.landing_catch_all);
Assert.assertNotNull("File type switch should exist", fileTypeSwitch);

// Test toggling the switch
onView(withId(R.id.landing_catch_all))
.perform(click());

// Switch should now be in opposite state
onView(withId(R.id.landing_catch_all))
.perform(click());

// Should be back to original state
// This test verifies the switch is functional and doesn't crash
}
}
89 changes: 89 additions & 0 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,95 @@
android:label="@string/app_title"
android:targetActivity="at.tomtasche.reader.ui.activity.MainActivity"
tools:ignore="AppLinkUrlError">
<!-- PDF files -->
<intent-filter>
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />

<data android:mimeType="application/pdf" />
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.BROWSABLE" />
<category android:name="android.intent.category.DEFAULT" />

<data android:scheme="content" />
<data android:scheme="file" />
<data android:host="*" />
<data android:pathPattern=".*\\.pdf" />
<data android:pathPattern=".*\\..*\\.pdf" />
<data android:pathPattern=".*\\..*\\..*\\.pdf" />
<data android:pathPattern=".*\\..*\\..*\\..*\\.pdf" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.pdf" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\.pdf" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\..*\\.pdf" />
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.BROWSABLE" />
<category android:name="android.intent.category.DEFAULT" />

<data android:mimeType="*/*" />
<data android:scheme="content" />
<data android:scheme="file" />
<data android:host="*" />
<data android:pathPattern=".*\\.pdf" />
<data android:pathPattern=".*\\..*\\.pdf" />
<data android:pathPattern=".*\\..*\\..*\\.pdf" />
<data android:pathPattern=".*\\..*\\..*\\..*\\.pdf" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.pdf" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\.pdf" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\..*\\.pdf" />
</intent-filter>
<!-- Microsoft Word DOC files -->
<intent-filter>
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />

<data android:mimeType="application/msword" />
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.BROWSABLE" />
<category android:name="android.intent.category.DEFAULT" />

<data android:scheme="content" />
<data android:scheme="file" />
<data android:host="*" />
<data android:pathPattern=".*\\.doc" />
<data android:pathPattern=".*\\..*\\.doc" />
<data android:pathPattern=".*\\..*\\..*\\.doc" />
<data android:pathPattern=".*\\..*\\..*\\..*\\.doc" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.doc" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\.doc" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\..*\\.doc" />
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.BROWSABLE" />
<category android:name="android.intent.category.DEFAULT" />

<data android:mimeType="*/*" />
<data android:scheme="content" />
<data android:scheme="file" />
<data android:host="*" />
<data android:pathPattern=".*\\.doc" />
<data android:pathPattern=".*\\..*\\.doc" />
<data android:pathPattern=".*\\..*\\..*\\.doc" />
<data android:pathPattern=".*\\..*\\..*\\..*\\.doc" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\.doc" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\.doc" />
<data android:pathPattern=".*\\..*\\..*\\..*\\..*\\..*\\..*\\.doc" />
</intent-filter>
<!-- OpenDocument formats -->
<intent-filter>
<action android:name="android.intent.action.VIEW" />

Expand Down