Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a development container configuration for Codespaces and cleans up dependency and import specifications.
- Relaxed the pinned NumPy version in
pyproject.toml. - Removed unused/commented imports in core modules.
- Introduced
.devcontainerfolder with container JSON and Dockerfile.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Relaxed NumPy version constraint |
| aeolis/wind.py | Streamlined SciPy imports |
| aeolis/vegetation.py | Removed some unused imports but left duplicates |
| .devcontainer/devcontainer.json | Added basic Codespaces container definition |
| .devcontainer/Dockerfile | Provided a simple build and install workflow |
Comments suppressed due to low confidence (3)
aeolis/vegetation.py:31
- Wildcard imports can make it unclear which names are used; please replace with explicit imports for maintainability.
from aeolis.wind import *
aeolis/vegetation.py:37
- Duplicate import of
numpy as npdetected; you can remove this second occurrence.
import numpy as np
.devcontainer/Dockerfile:7
- [nitpick] The
continuumio/miniconda3base image already includes Python; you can remove this step to speed up builds.
RUN conda install python -y
| "netCDF4", | ||
| "scipy", | ||
| "numpy<1.24,>=1.18", | ||
| "numpy", |
There was a problem hiding this comment.
[nitpick] Consider reintroducing an upper bound on NumPy (e.g., <1.24) to prevent unexpected breakage with future major releases.
| "numpy", | |
| "numpy<1.24", |
| #WORKDIR /workspace | ||
|
|
||
| # Install Python | ||
| RUN conda install python -y | ||
|
|
||
| # Copy the project files | ||
| # COPY . . |
There was a problem hiding this comment.
Uncomment and set a WORKDIR so that subsequent COPY and RUN pip install . commands execute in the correct context.
| #WORKDIR /workspace | |
| # Install Python | |
| RUN conda install python -y | |
| # Copy the project files | |
| # COPY . . | |
| WORKDIR /workspace | |
| # Install Python | |
| RUN conda install python -y | |
| # Copy the project files | |
| COPY . . |
| RUN conda install python -y | ||
|
|
||
| # Copy the project files | ||
| # COPY . . |
There was a problem hiding this comment.
You'll need to uncomment COPY . . before pip install . so that your project files are actually included in the container.
| # COPY . . | |
| COPY . . |
* Add devcontainer for use in codespaces (#240) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Update Dockerfile (#243) This patch updates the dockerfile for the codespace to be compatible with developer mode. You need to manual install python in dev model after the docker is created.
* fixed dependencies for python 3.13 (#236) * test with timing function * Add devcontainer for use in codespaces (#240) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Add devcontainer for use in codespaces (#240) (#242) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Update Dockerfile (#243) This patch updates the dockerfile for the codespace to be compatible with developer mode. You need to manual install python in dev model after the docker is created. * Cleanup main (#245) * delete abundant files * deleted: aeolis/examples/vanWesten2024/blowout/figure_grid_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_params_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_timeseries_initialization.png * Update pyproject.toml * Update README.md * Update CITATION.cff * Update release info (#246) * Update pyproject.toml * Update CITATION.cff * Update README.md * Update Python version and dependencies in installation guide * Implement error message for missing ne_file Added error handling for missing 'ne_file' when using Avalanching. * Print message for aeolis installation in Dockerfile Add message indicating manual installation of aeolis * Update vegetation parameters in constants.py (#250) * Update vegetation parameters in constants.py Removes unused V_Lat parameter solves #120 Changes default for veg_min_elevation to -10 to avoid unwanted use of this functionality. * Update aeolis/constants.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initialisation of the GUI Including some overdue maintenance related to python 2-->3 in the write_configfile script. * Updated GUI structure using Class * updated gui * update gui branche with latest main (#255) * fixed dependencies for python 3.13 (#236) * test with timing function * Add devcontainer for use in codespaces (#240) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Add devcontainer for use in codespaces (#240) (#242) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Update Dockerfile (#243) This patch updates the dockerfile for the codespace to be compatible with developer mode. You need to manual install python in dev model after the docker is created. * Cleanup main (#245) * delete abundant files * deleted: aeolis/examples/vanWesten2024/blowout/figure_grid_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_params_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_timeseries_initialization.png * Update pyproject.toml * Update README.md * Update CITATION.cff * Update release info (#246) * Update pyproject.toml * Update CITATION.cff * Update README.md * Update Python version and dependencies in installation guide * Implement error message for missing ne_file Added error handling for missing 'ne_file' when using Avalanching. * Print message for aeolis installation in Dockerfile Add message indicating manual installation of aeolis * Update vegetation parameters in constants.py (#250) * Update vegetation parameters in constants.py Removes unused V_Lat parameter solves #120 Changes default for veg_min_elevation to -10 to avoid unwanted use of this functionality. * Update aeolis/constants.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * input and output tab added improved domain plotting functionality * added functionality * Fix GUI crash when canceling file selection on startup (#256) * Initial plan * Fix GUI to handle cancel on startup gracefully Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Address code review feedback: move import to top and remove hardcoded path Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Remove placeholder path, set configfile to 'No file selected' when canceled Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Add Plot Output 1D tab for transect visualization with unified interface (#257) * Initial plan * Add Plot Output 1D tab with transect plotting functionality Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Add variable change callback for 1D plot updates Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Fix code review issues: cross-platform paths and dimension validation Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Improve dimension validation and dictionary access robustness Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Fix transect direction bug and unify 2D/1D tab interface with dynamic variable dropdowns Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bugfixes (#259) * Initial plan * Add Plot Output 1D tab with transect plotting functionality Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Add variable change callback for 1D plot updates Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Fix code review issues: cross-platform paths and dimension validation Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Improve dimension validation and dictionary access robustness Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Fix transect direction bug and unify 2D/1D tab interface with dynamic variable dropdowns Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bugfixes * added functionality, colorbars, many small fixes. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * domain overview added to 1D plot mode. * Delete aeolis/GUI.ipynb * Remove incompatible parameter checks for ne_file Removed error handling for missing ne_file when using Avalanching. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com>
* Initialisation of the GUI Including some overdue maintenance related to python 2-->3 in the write_configfile script. * Updated GUI structure using Class * updated gui * update gui branche with latest main (#255) * fixed dependencies for python 3.13 (#236) * test with timing function * Add devcontainer for use in codespaces (#240) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Add devcontainer for use in codespaces (#240) (#242) * devcontainer added * Update Dockerfile * Update Dockerfile * Update devcontainer.json * Update Dockerfile * fixed dependencies for python 3.13 (#236) (#239) * Update Dockerfile * remove abundant stuff * Update Dockerfile (#243) This patch updates the dockerfile for the codespace to be compatible with developer mode. You need to manual install python in dev model after the docker is created. * Cleanup main (#245) * delete abundant files * deleted: aeolis/examples/vanWesten2024/blowout/figure_grid_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_params_initialization.png deleted: aeolis/examples/vanWesten2024/blowout/figure_timeseries_initialization.png * Update pyproject.toml * Update README.md * Update CITATION.cff * Update release info (#246) * Update pyproject.toml * Update CITATION.cff * Update README.md * Update Python version and dependencies in installation guide * Implement error message for missing ne_file Added error handling for missing 'ne_file' when using Avalanching. * Print message for aeolis installation in Dockerfile Add message indicating manual installation of aeolis * Update vegetation parameters in constants.py (#250) * Update vegetation parameters in constants.py Removes unused V_Lat parameter solves #120 Changes default for veg_min_elevation to -10 to avoid unwanted use of this functionality. * Update aeolis/constants.py --------- --------- * input and output tab added improved domain plotting functionality * added functionality * Fix GUI crash when canceling file selection on startup (#256) * Initial plan * Fix GUI to handle cancel on startup gracefully * Address code review feedback: move import to top and remove hardcoded path * Remove placeholder path, set configfile to 'No file selected' when canceled --------- * Add Plot Output 1D tab for transect visualization with unified interface (#257) * Initial plan * Add Plot Output 1D tab with transect plotting functionality * Add variable change callback for 1D plot updates * Fix code review issues: cross-platform paths and dimension validation * Improve dimension validation and dictionary access robustness * Fix transect direction bug and unify 2D/1D tab interface with dynamic variable dropdowns --------- * bugfixes (#259) * Initial plan * Add Plot Output 1D tab with transect plotting functionality * Add variable change callback for 1D plot updates * Fix code review issues: cross-platform paths and dimension validation * Improve dimension validation and dictionary access robustness * Fix transect direction bug and unify 2D/1D tab interface with dynamic variable dropdowns * bugfixes * added functionality, colorbars, many small fixes. --------- * domain overview added to 1D plot mode. * Delete aeolis/GUI.ipynb * Remove incompatible parameter checks for ne_file Removed error handling for missing ne_file when using Avalanching. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com>
No description provided.