FEDX-507 Fix issue with watcher assets for LMS and Studio services. by ztraboo · Pull Request #376 · openedx-unsupported/devstack

ztraboo · 2018-12-18T20:06:25Z

Would like to make sure that the watchers for LMS and Studio services for docker_devstack are working properly. Error was occurring since /edx/app/edxapp/edx-platform/node_modules volume mapping was missing.
https://openedx.atlassian.net/browse/FEDX-507?focusedCommentId=353646&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-353646

Ref: https://github.com/edx/devstack/pull/375 (Closed - Todo: cherry pick to hawthorn).

openedx-webhooks · 2018-12-18T20:06:39Z

Thanks for the pull request, @ztraboo! I've created OSPR-2915 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

supporting documentation
edx-code email threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information.

natabene · 2018-12-19T03:31:26Z

@ztraboo Thank you for the contribution! When you have a chance, could you please send in a signed Contributor Agreement mentioned in the earlier comment? You only need to do this once and we can then review all your future code contributions.

ztraboo · 2018-12-19T12:10:30Z

@natabene I sent my signed CA document into edX legal yesterday afternoon.

From: Zachary J Trabookis ztraboo@clemson.edu
Sent: Tuesday, December 18, 2018 1:52 PM
To: legal@edx.org
Subject: Open edX - Contributor Agreement - Zachary Trabookis (ztraboo)

natabene · 2018-12-19T18:37:27Z

@ztraboo Thank you, once our team processes it, I will post an update here.

natabene · 2019-03-18T17:13:12Z

@ztraboo Thank you for joining the Open edX community! We have added your user to our records and can now review your code going forward. Please let let me know once all checks are green.

natabene · 2019-03-18T17:13:59Z

@edx/testeng Do you happen to know why travis is pending here?

ztraboo · 2019-03-18T19:50:34Z

@natabene It appears that when you go into the details fo the Travis build it successfully passes. Not sure why we're seeing a pending state in Github. Does Travis notify Github that it's done with the build? Wonder if the pending has to do with the Contributor Agreement status not being complete for my account when I created this pull request. Do I need to do anything on my end to update the Travis status?

cc: @edx/testeng

natabene · 2019-03-18T20:24:43Z

@ztraboo Contributor status has not no impact on tests. Let's see if @edx/testeng can shed any light on this.

jmbowman · 2019-03-19T15:52:06Z

Travis was configured on this repo both as a service (which is a deprecated GitHub feature) and a webhook, there may have been some confusion between the two communication methods. I just removed the service configuration, that might help for future runs.

natabene · 2019-04-08T20:47:53Z

@jmbowman continuous integration is still pending, anything I can do about it?

jmbowman · 2019-04-09T19:58:01Z

I reran the job in Travis, GitHub apparently got the notification this time.

natabene · 2019-04-10T15:24:35Z

@jmbowman Thanks! Would you like to review/approve/merge this?

natabene · 2019-04-10T15:29:43Z

@edx/fedx-team Could you give this a look? @jmbowman feels you have better insight into static asset management in devstack.

matthugs · 2019-04-19T19:46:27Z

It seems curious to me that we wouldn't've applied this change in the wake of https://github.com/edx/devstack/pull/259, but this looks quite reasonable to me.

It's pretty clear that we're not changing any of the intended aspects of our docker setup here, e.g. need to be in a container shell to update node dependencies. I think we should be able to pass this off fairly quickly, but I'd love a second pair of eyes from the @edx/fedx-team to double-check me.

Thanks for this, @ztraboo!

openedx-webhooks · 2019-04-26T19:27:57Z

@ztraboo 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377

https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup.

…tainers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup.

…tainers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup. Additional changes needed to make `docker` commands work making use of the `dev.print-container.%` target to get the container id. Reverting some of these commands back to `docker` type to align with what we did with edx/devstack@59f812e Updated `README` to include necessary information when running multiple isolated devstacks for same host. Make additional adjustments to the documentation for multiple releases one machine. Add `xqueue` to default services to provision initially. Make sure to pass in `DOCKER_COMPOSE_FILES` to `docker-compose exec` commands for services outside of `docker-compose.yml`. Makes sure that other services (e.g. `xqueue`, etc) that are not defined in the docker-compose.yml file have the correct configuration passed to the `docker-compose exec` command to work properly.

…tainers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup.

…tainers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup. Additional changes needed to make `docker` commands work making use of the `dev.print-container.%` target to get the container id. Reverting some of these commands back to `docker` type to align with what we did with edx/devstack@59f812e

…ers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request openedx-unsupported#532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. openedx-unsupported#376 openedx-unsupported#377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup. Additional changes needed to make `docker` commands work making use of the `dev.print-container.%` target to get the container id. Reverting some of these commands back to `docker` type to align with what we did with 59f812e

…tainers for multi-version devstack support https://discuss.openedx.org/t/docker-devstack-multiple-releases-one-machine/1902 Multiple devstack releases with one machine. This is in regards to this pull request https://github.com/edx/devstack/pull/532 Updating volumes for `themes` to work with the `ironwood` release. Applying these changes to get local devstack working for ironwood release. https://github.com/edx/devstack/pull/376 https://github.com/edx/devstack/pull/377 Moved `COMPOSE_PROJECT_NAME` update to `options.mk` file. Additional changes to get `devstack_docker` for Ironwood working multisite environment setup. Additional changes needed to make `docker` commands work making use of the `dev.print-container.%` target to get the container id. Reverting some of these commands back to `docker` type to align with what we did with edx/devstack@59f812e

FEDX-507 Fix issue with watcher assets for LMS and Studio services.

b699ad2

openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Dec 18, 2018

openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage labels Dec 19, 2018

openedx-webhooks added open edx community review waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. open edx community review labels Feb 8, 2019

openedx-webhooks added community manager review and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Feb 15, 2019

openedx-webhooks added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed community manager review labels Mar 18, 2019

openedx-webhooks added awaiting prioritization and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels Apr 10, 2019

natabene requested a review from matthugs April 19, 2019 20:32

ztraboo mentioned this pull request Jul 24, 2020

[Backport] Multiple devstack releases with one machine #564

Merged

openedx-webhooks added merged and removed engineering review labels Jan 22, 2021

Uh oh!

Conversation

ztraboo commented Dec 18, 2018

Uh oh!

openedx-webhooks commented Dec 18, 2018

Uh oh!

natabene commented Dec 19, 2018

Uh oh!

ztraboo commented Dec 19, 2018

Uh oh!

natabene commented Dec 19, 2018

Uh oh!

natabene commented Mar 18, 2019

Uh oh!

natabene commented Mar 18, 2019

Uh oh!

ztraboo commented Mar 18, 2019

Uh oh!

natabene commented Mar 18, 2019

Uh oh!

jmbowman commented Mar 19, 2019

Uh oh!

natabene commented Apr 8, 2019

Uh oh!

jmbowman commented Apr 9, 2019

Uh oh!

natabene commented Apr 10, 2019

Uh oh!

natabene commented Apr 10, 2019

Uh oh!

matthugs commented Apr 19, 2019

Uh oh!

openedx-webhooks commented Apr 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants