Updated `README` to include necessary information when running multiple isolated devstacks for same host. by ztraboo · Pull Request #569 · openedx-unsupported/devstack

ztraboo · 2020-07-27T20:59:45Z

This is the documentation needed for https://github.com/edx/devstack/pull/532

@kdmccormick, @jmbowman, @arbrandes, @regisb

.

openedx-webhooks · 2020-07-27T20:59:49Z

Thanks for the pull request, @ztraboo! I've created OSPR-4866 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

ztraboo · 2020-07-27T21:02:28Z

Ready for edX review.

regisb · 2020-07-28T15:38:01Z

FYI I'll be away from keyboard until Aug. 3rd, so I won't be able to revert my review until then.

ztraboo · 2020-07-28T16:21:18Z

@regisb I made your recommended changes above. Please review https://github.com/CUCWD/devstack/blob/ztraboo/multiple-releases-one-machine-u1/README.rst#how-do-i-run-multiple-named-open-edx-releases-on-same-machine when you can. Thanks.

ztraboo · 2020-07-28T17:05:53Z

@regisb I made those changes here https://github.com/CUCWD/devstack/tree/ztraboo/multiple-releases-one-machine-u1#how-do-i-run-multiple-named-open-edx-releases-on-same-machine. Please review when you have time.

natabene · 2020-07-29T01:20:37Z

@nedbat This is ready, do you have some time to review it?

regisb

A few additional minor changes are required. We're almost there!

ztraboo · 2020-08-10T19:32:42Z

@regisb Sorry I was out last week. Please review changes with edx/devstack@c0b482d and let me know if you need me to revise anything.

natabene · 2020-08-12T01:52:47Z

@regisb Thanks for reviewing this. CC @kdmccormick @jmbowman

regisb

Please make sure all outstanding conversations can be resolved.

@kdmccormick

…le isolated devstacks for same host. This is the documentation needed for https://github.com/edx/devstack/pull/532 @kdmccormick, @jmbowman, @arbrandes, @regisb

…s one machine.

ztraboo · 2020-08-15T20:19:51Z

@regisb Once we get this readme resolved I'll apply those changes to https://github.com/edx/devstack/pull/564 too. Thanks for the review.

@regisb

…nging releases. - These were additional review changes requested by @regisb.

…or the `readme` file. - All changes from https://github.com/edx/devstack/pull/569 changes from this.

@regisb

- Fixing review from @regisb

openedx-webhooks · 2020-08-17T08:42:11Z

@ztraboo 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

regisb · 2020-08-17T08:42:25Z

Thanks for your patience and cooperation @ztraboo!

ztraboo · 2020-08-17T12:25:02Z

No problem @regisb. I appreciate a thorough review. Helps me code better. :)

@morenol

…s one machine (regisb review). Comments came from `master` edx/devstack@c0b482d Fix issue with `docker-compose config` not outputting configuration information when `$(DOCKER_COMPOSE_FILES)` was excluded from the command. It appears that leaving out `$(DOCKER_COMPOSE_FILES)` caused the `docker-compose config` to not include the **volume** information for services within the `docker-compose.yml` file, as well as, excluding additional services like `docker-compose-{analytics-pipeline,watchers}.yml` to name a few. Update provision-ecommerce.sh with recommended changes from @morenol Co-authored-by: morenol <13-10934@usb.ve> Merging additional updates based on openedx-unsupported#569 changes for the `readme` file. - All changes from https://github.com/edx/devstack/pull/569 changes from this.

@morenol

…s one machine (regisb review). Comments came from `master` edx/devstack@c0b482d Fix issue with `docker-compose config` not outputting configuration information when `$(DOCKER_COMPOSE_FILES)` was excluded from the command. It appears that leaving out `$(DOCKER_COMPOSE_FILES)` caused the `docker-compose config` to not include the **volume** information for services within the `docker-compose.yml` file, as well as, excluding additional services like `docker-compose-{analytics-pipeline,watchers}.yml` to name a few. Update provision-ecommerce.sh with recommended changes from @morenol Co-authored-by: morenol <13-10934@usb.ve> Merging additional updates based on #569 changes for the `readme` file. - All changes from https://github.com/edx/devstack/pull/569 changes from this.

@morenol

…s one machine (regisb review). Comments came from `master` edx/devstack@c0b482d Fix issue with `docker-compose config` not outputting configuration information when `$(DOCKER_COMPOSE_FILES)` was excluded from the command. It appears that leaving out `$(DOCKER_COMPOSE_FILES)` caused the `docker-compose config` to not include the **volume** information for services within the `docker-compose.yml` file, as well as, excluding additional services like `docker-compose-{analytics-pipeline,watchers}.yml` to name a few. Update provision-ecommerce.sh with recommended changes from @morenol Co-authored-by: morenol <13-10934@usb.ve> Merging additional updates based on openedx-unsupported#569 changes for the `readme` file. - All changes from https://github.com/edx/devstack/pull/569 changes from this.

@morenol

…s one machine (regisb review). Comments came from `master` edx/devstack@c0b482d Fix issue with `docker-compose config` not outputting configuration information when `$(DOCKER_COMPOSE_FILES)` was excluded from the command. It appears that leaving out `$(DOCKER_COMPOSE_FILES)` caused the `docker-compose config` to not include the **volume** information for services within the `docker-compose.yml` file, as well as, excluding additional services like `docker-compose-{analytics-pipeline,watchers}.yml` to name a few. Update provision-ecommerce.sh with recommended changes from @morenol Co-authored-by: morenol <13-10934@usb.ve> Merging additional updates based on openedx-unsupported#569 changes for the `readme` file. - All changes from https://github.com/edx/devstack/pull/569 changes from this.

openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Jul 27, 2020

ztraboo mentioned this pull request Jul 27, 2020

[Backport] Multiple devstack releases with one machine #564

Merged

ztraboo force-pushed the ztraboo/multiple-releases-one-machine-u1 branch from 693e9c8 to 574d744 Compare July 27, 2020 21:29

regisb suggested changes Jul 28, 2020

View reviewed changes

ztraboo force-pushed the ztraboo/multiple-releases-one-machine-u1 branch 2 times, most recently from 02985eb to b3d3fd3 Compare July 28, 2020 16:14

regisb reviewed Jul 28, 2020

View reviewed changes

Comment thread README.rst Outdated

regisb reviewed Jul 28, 2020

View reviewed changes

Comment thread README.rst Outdated

regisb reviewed Jul 28, 2020

View reviewed changes

Comment thread README.rst Outdated

ztraboo force-pushed the ztraboo/multiple-releases-one-machine-u1 branch from b3d3fd3 to f5a74ca Compare July 28, 2020 17:05

openedx-webhooks added awaiting prioritization and removed needs triage labels Jul 29, 2020

ztraboo force-pushed the ztraboo/multiple-releases-one-machine-u1 branch 2 times, most recently from 92966f0 to c96d65e Compare July 29, 2020 18:07

natabene requested a review from nedbat July 30, 2020 01:19

regisb suggested changes Aug 2, 2020

View reviewed changes

Comment thread README.rst

Comment thread README.rst Outdated

Comment thread README.rst Outdated

openedx-webhooks added needs triage and removed awaiting prioritization labels Aug 8, 2020

ztraboo force-pushed the ztraboo/multiple-releases-one-machine-u1 branch from c96d65e to b4e7ff0 Compare August 10, 2020 19:29

ztraboo force-pushed the ztraboo/multiple-releases-one-machine-u1 branch from b4e7ff0 to c0b482d Compare August 10, 2020 19:38

natabene removed the needs triage label Aug 12, 2020

natabene added the open edx community review label Aug 12, 2020

regisb reviewed Aug 15, 2020

View reviewed changes

Comment thread README.rst Outdated

regisb reviewed Aug 15, 2020

View reviewed changes

Comment thread README.rst Outdated

openedx-webhooks added needs triage and removed open edx community review labels Aug 15, 2020

regisb suggested changes Aug 15, 2020

View reviewed changes

ztraboo added 3 commits August 15, 2020 15:14

Updated README to include necessary information when running multip…

9be4edf

…le isolated devstacks for same host. This is the documentation needed for https://github.com/edx/devstack/pull/532 @kdmccormick, @jmbowman, @arbrandes, @regisb

Make additional adjustments to the documentation for multiple release…

5c2514a

…s one machine.

Updated few additional minor changes required by regisb review.

961eddd

ztraboo force-pushed the ztraboo/multiple-releases-one-machine-u1 branch from c0b482d to 52c629e Compare August 15, 2020 20:17

Fixing recommended changes for direnv into separate section for cha…

2c799a0

…nging releases. - These were additional review changes requested by @regisb.

ztraboo force-pushed the ztraboo/multiple-releases-one-machine-u1 branch from 52c629e to 2c799a0 Compare August 16, 2020 15:51

ztraboo added a commit to CUCWD/devstack that referenced this pull request Aug 17, 2020

Merging additional updates based on openedx-unsupported#569 changes f…

394df38

…or the `readme` file. - All changes from https://github.com/edx/devstack/pull/569 changes from this.

ztraboo added a commit to CUCWD/devstack that referenced this pull request Aug 17, 2020

Merging additional updates based on openedx-unsupported#569 changes f…

a9edb6e

…or the `readme` file. - All changes from https://github.com/edx/devstack/pull/569 changes from this.

ztraboo added a commit to CUCWD/devstack that referenced this pull request Aug 17, 2020

Merging additional updates based on openedx-unsupported#569 changes f…

f2b4b87

…or the `readme` file. - All changes from https://github.com/edx/devstack/pull/569 changes from this.

ztraboo added a commit to CUCWD/devstack that referenced this pull request Aug 17, 2020

Merging additional updates based on openedx-unsupported#569 changes f…

b73a147

…or the `readme` file. - All changes from https://github.com/edx/devstack/pull/569 changes from this.

Additional clarification changes needed for readme.

149bc79

- Fixing review from @regisb

ztraboo force-pushed the ztraboo/multiple-releases-one-machine-u1 branch from 89ff8de to 149bc79 Compare August 17, 2020 02:44

regisb approved these changes Aug 17, 2020

View reviewed changes

regisb merged commit c958084 into openedx-unsupported:master Aug 17, 2020

openedx-webhooks added the merged label Aug 17, 2020

openedx-webhooks removed the needs triage label Jan 21, 2021

Uh oh!

Conversation

ztraboo commented Jul 27, 2020 • edited by nedbat Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openedx-webhooks commented Jul 27, 2020

Uh oh!

ztraboo commented Jul 27, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

regisb commented Jul 28, 2020

Uh oh!

ztraboo commented Jul 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ztraboo commented Jul 28, 2020

Uh oh!

natabene commented Jul 29, 2020

Uh oh!

regisb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ztraboo commented Aug 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

natabene commented Aug 12, 2020

Uh oh!

Uh oh!

Uh oh!

regisb left a comment

Choose a reason for hiding this comment

Uh oh!

ztraboo commented Aug 15, 2020

Uh oh!

openedx-webhooks commented Aug 17, 2020

Uh oh!

regisb commented Aug 17, 2020

Uh oh!

ztraboo commented Aug 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ztraboo commented Jul 27, 2020 •

edited by nedbat

Loading

ztraboo commented Aug 10, 2020 •

edited

Loading