This repository was archived by the owner on Aug 1, 2024. It is now read-only.
Remove xqueue from DEFAULT_SERVICES fix for PR #564. - #599
Merged
Conversation
As discussed with @kdmccormick here edx/devstack@57455fe#commitcomment-41529836 we decided to remove `xqueue` since it is not needed by default devstack setup. This is a fix to recent PR https://github.com/edx/devstack/pull/564.
openedx-webhooks
added
needs triage
open-source-contribution
|
Thanks for the pull request, @ztraboo! I've created OSPR-4899 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
ztraboo
referenced
this pull request
Aug 17, 2020
Contributor
Author
|
@natabene Ready for review. |
|
@ztraboo 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
regisb
approved these changes
Aug 17, 2020
Contributor
Author
|
Thanks @regisb! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @kdmccormick here edx/devstack@57455fe#commitcomment-41529836 we decided to remove
xqueuesince it is not needed by default devstack setup.This is a fix to recent PR https://github.com/edx/devstack/pull/564 and only applies to Juniper release at the moment.
cc: @kdmccormick, @regisb