Skip to content

[BD-13] depr: deprecated the user_id attribute - #542

Merged
symbolist merged 1 commit into
openedx:masterfrom
open-craft:jill/BD-13-user-service
Aug 30, 2021
Merged

[BD-13] depr: deprecated the user_id attribute#542
symbolist merged 1 commit into
openedx:masterfrom
open-craft:jill/BD-13-user-service

Conversation

@pomegranited

@pomegranited pomegranited commented Aug 13, 2021

Copy link
Copy Markdown
Contributor

Description

The user_id should be fetched from the 'user' service, not stored in the Runtime.

This change should not affect Learners, Course Authors, or anyone else using edx-platform.

Supporting information

Testing instructions

See https://github.com/edx/edx-platform/pull/28440 for testing instructions and sandbox.

Deadline

None

Other information

@openedx-webhooks

openedx-webhooks commented Aug 13, 2021

Copy link
Copy Markdown

Thanks for the pull request, @pomegranited! I've created BLENDED-940 to keep track of it in Jira. More details are on the BD-13 project page.

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program needs triage labels Aug 13, 2021
@pomegranited
pomegranited marked this pull request as draft August 13, 2021 07:08
@pomegranited
pomegranited marked this pull request as ready for review August 20, 2021 07:26

@symbolist symbolist left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this as part of https://github.com/edx/edx-platform/pull/28440. Good to go. 👍🏽

@symbolist

Copy link
Copy Markdown
Contributor

@pomegranited Can you rebase this? I'll merge once it is green.

@pomegranited
pomegranited force-pushed the jill/BD-13-user-service branch from 21db3b2 to e50ca15 Compare August 26, 2021 23:09
@symbolist

Copy link
Copy Markdown
Contributor

@pomegranited Just realized we missed bumping up the version number and adding a changelog entry. 🙂

This value should be fetched from the 'user' service.
@pomegranited
pomegranited force-pushed the jill/BD-13-user-service branch from e50ca15 to 71de7d0 Compare August 28, 2021 05:33
@pomegranited

Copy link
Copy Markdown
Contributor Author

@symbolist Oops, thank you for catching that! I've bumped the version to 1.5.1, added a CHANGELOG entry, and squashed my commits back down to 1.

@symbolist
symbolist merged commit b5f1258 into openedx:master Aug 30, 2021
@openedx-webhooks

Copy link
Copy Markdown

@pomegranited 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants