Skip to content

fix: added logout user before sso pipeline starts - #402

Merged
feanil merged 5 commits into
openedx:masterfrom
Akanshu-2u:BOMS-3-track-update-email-bug-in-third-party-auth-email-update
Sep 30, 2025
Merged

fix: added logout user before sso pipeline starts#402
feanil merged 5 commits into
openedx:masterfrom
Akanshu-2u:BOMS-3-track-update-email-bug-in-third-party-auth-email-update

Conversation

@Akanshu-2u

@Akanshu-2u Akanshu-2u commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Description:

Users logging in through OAuth SSO could retain session data from previous logins, creating potential security risks and confusion when switching between accounts.

Solution:

Added logout(request) call in EdXOAuth2.start() method to clear existing sessions before OAuth authentication begins.

JIRA:

BOMS-3

Note:

@Akanshu-2u
Akanshu-2u requested a review from robrap September 25, 2025 05:35
Comment thread auth_backends/backends.py Outdated
@Akanshu-2u
Akanshu-2u requested a review from robrap September 26, 2025 07:20
@feanil

feanil commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

@Akanshu-2u changes look good, can you bump the version of the library so that we can do a release once we merge this?

@Akanshu-2u

Copy link
Copy Markdown
Contributor Author

@Akanshu-2u changes look good, can you bump the version of the library so that we can do a release once we merge this?

Addressed. Added version bump of the library. Thank you.

@Akanshu-2u
Akanshu-2u requested a review from feanil September 30, 2025 04:05
@feanil
feanil merged commit fb50db2 into openedx:master Sep 30, 2025
12 checks passed
@robrap
robrap deleted the BOMS-3-track-update-email-bug-in-third-party-auth-email-update branch September 30, 2025 15:22
@robrap

robrap commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Thanks @feanil.

@robrap

robrap commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

@feanil: We'll see if we can get this fully tested and rolled out (on by default) for Ulmo on Oct 9.
FYI: @Akanshu-2u

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants