[BD-21] Multiline annotations with single-line comment prefix ("#") - #48
Merged
robrap merged 2 commits intoSep 2, 2020
Merged
Conversation
|
Thanks for the pull request, @regisb! I've created BLENDED-564 to keep track of it in Jira. More details are on the BD-21 project page. When this pull request is ready, tag your edX technical lead. |
openedx-webhooks
added
blended
regisb
force-pushed
the
regisb/multiline-with-singlelinecomment
branch
from
August 27, 2020 14:54
fd204c4 to
d46aeb9
Compare
regisb
force-pushed
the
regisb/multiline-with-singlelinecomment
branch
3 times, most recently
from
August 27, 2020 15:10
58546d9 to
8539c26
Compare
robrap
reviewed
Aug 28, 2020
robrap
left a comment
robrap
left a comment
Contributor
There was a problem hiding this comment.
Thanks. I don't think it is far off.
regisb
force-pushed
the
regisb/multiline-with-singlelinecomment
branch
6 times, most recently
from
August 31, 2020 13:19
a26b3cf to
b090d6a
Compare
robrap
reviewed
Aug 31, 2020
regisb
force-pushed
the
regisb/multiline-with-singlelinecomment
branch
2 times, most recently
from
September 1, 2020 09:22
021a255 to
a3e83d9
Compare
robrap
approved these changes
Sep 1, 2020
Multiline annotations were previously supported only for multi-line
comments. In Python: """..."""
This introduces multiline annotations for comments prefixed by
single-line comment signs. In Python:
# .. pii: a multiline annotation
# that spans multiple lines.
This makes it possible to wrap long comment lines more naturally, in
particular in Python.
regisb
force-pushed
the
regisb/multiline-with-singlelinecomment
branch
from
September 2, 2020 07:24
a3e83d9 to
097db99
Compare
Contributor
Author
|
@robrap: This is ready to merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Multiline annotations were previously supported only for multi-line comments. In Python: """..."""
This introduces multiline annotations for comments prefixed by single-line comment signs. In Python:
This makes it possible to wrap long comment lines more naturally, in particular in Python.
JIRA: https://openedx.atlassian.net/wiki/spaces/COMM/pages/1596358943
Dependencies: This feature can be tested on this PR: https://github.com/edx/edx-platform/pull/24815
Reviewers:
Merge checklist:
Documentation updated (not only docstrings)Post merge:
finished.