feat: created skills_level API to fetch learner skill levels - #31417
Merged
Conversation
sameenfatima78
changed the title
sameenfatima78
requested review from
HammadAhmadWaqas,
irfanuddinahmad,
muhammad-ammar,
saleem-latif and
zamanafzal
December 13, 2022 12:52
HammadAhmadWaqas
suggested changes
Dec 13, 2022
HammadAhmadWaqas
suggested changes
Dec 16, 2022
HammadAhmadWaqas
left a comment
HammadAhmadWaqas
left a comment
Member
There was a problem hiding this comment.
Could you please example response on the PR description as well?
Member
Author
@HammadAhmadWaqas Example responses are already added in the description. |
sameenfatima78
force-pushed
the
sameen/ENT-6403-try1
branch
4 times, most recently
from
December 21, 2022 11:01
a6feeba to
7dcd5f1
Compare
sameenfatima78
force-pushed
the
sameen/ENT-6403-try1
branch
3 times, most recently
from
January 3, 2023 08:58
21c1c18 to
db263c1
Compare
HammadAhmadWaqas
approved these changes
Jan 3, 2023
sameenfatima78
force-pushed
the
sameen/ENT-6403-try1
branch
from
January 3, 2023 11:53
db263c1 to
5b385c2
Compare
added api to retrieve learner levels incorporated feedback added tests and incorporated feedback 2 incorporated feedback round 2 added tests in views and utilities fixed one test input fixed failing test fixed failing test try 2 fixing failing test try 3 fixing test added new utility and test fixed failing test in student app
sameenfatima78
force-pushed
the
sameen/ENT-6403-try1
branch
from
January 4, 2023 11:40
5b385c2 to
36e666c
Compare
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created an API that:
With skills matched
With no skills matched
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.
Useful information to include:
"Developer", and "Operator".
changes.
Supporting information
Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.