Skip to content

fix: update frontend-build to fix install issues (FC-0094) - #2387

Merged
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:samuel/update-frontend-build
Sep 2, 2025
Merged

fix: update frontend-build to fix install issues (FC-0094)#2387
bradenmacdonald merged 1 commit into
openedx:masterfrom
open-craft:samuel/update-frontend-build

Conversation

@samuelallan72

@samuelallan72 samuelallan72 commented Aug 19, 2025

Copy link
Copy Markdown

Description

Earlier versions of @openedx/frontend-build used on older version of 'sharp', which caused intermittent installation issues. The version of 'sharp' was updated in @openedx/frontend-build to fix these issues, so the frontend-build version can be updated here, to fix the issues in this project too. See openedx/frontend-build#664 (issue) and openedx/frontend-build#665 (PR) for more information.

The frontend-build dependency was updated by:

npm install --package-lock-only @openedx/frontend-build

Supporting information

Private-ref: https://tasks.opencraft.com/browse/BB-9953

Testing instructions

  • run npm ci to install dependencies
  • verify that the installation completes successfully
  • verify that the expected versions of share and frontend-build are installed:
$ npm list -a | grep -E 'frontend-build|sharp@'
│ ├── @openedx/frontend-build@14.6.2 deduped
├─┬ @openedx/frontend-build@14.6.2
│ ├─┬ sharp@0.34.3
  • repeat several times and verify the installation completes successfully each time (we're looking to see that this fixes openedx/frontend-build#664).

Other information

N/A

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 19, 2025
@openedx-webhooks

openedx-webhooks commented Aug 19, 2025

Copy link
Copy Markdown

Thanks for the pull request, @samuelallan72!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Aug 19, 2025
@kaustavb12 kaustavb12 added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Aug 19, 2025
@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

1 similar comment
@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

1 similar comment
@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@codecov

codecov Bot commented Aug 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.60%. Comparing base (950bfee) to head (68f57cb).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2387    +/-   ##
========================================
  Coverage   94.60%   94.60%            
========================================
  Files        1179     1179            
  Lines       25506    25506            
  Branches     5449     5591   +142     
========================================
  Hits        24129    24129            
+ Misses       1314     1309     -5     
- Partials       63       68     +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Aug 21, 2025
@samuelallan72
samuelallan72 force-pushed the samuel/update-frontend-build branch from 580ad37 to ec160d3 Compare September 1, 2025 04:48
@samuelallan72 samuelallan72 changed the title wip: chore: update frontend-build dependency fix: update frontend-build to fix install issues Sep 1, 2025
@samuelallan72 samuelallan72 self-assigned this Sep 1, 2025
@samuelallan72
samuelallan72 force-pushed the samuel/update-frontend-build branch from ec160d3 to 52952f7 Compare September 1, 2025 04:50
Earlier versions of @openedx/frontend-build used on older version of
'sharp', which caused intermittent installation issues. The version of
'sharp' was updated in @openedx/frontend-build to fix these issues, so
the frontend-build version can be updated here, to fix the issues in
this project too. See
openedx/frontend-build#664 and
openedx/frontend-build#665 for more information.

The frontend-build dependency was updated by:

```
npm install --package-lock-only @openedx/frontend-build
```

Private-ref: https://tasks.opencraft.com/browse/BB-9953
@samuelallan72
samuelallan72 force-pushed the samuel/update-frontend-build branch from 52952f7 to 68f57cb Compare September 1, 2025 04:55
@samuelallan72
samuelallan72 marked this pull request as ready for review September 1, 2025 05:05
@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@kaustavb12 kaustavb12 removed the create-sandbox open-craft-grove should create a sandbox environment from this PR label Sep 2, 2025
@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove

Copy link
Copy Markdown

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@kaustavb12

Copy link
Copy Markdown
Contributor

LGTM 👍

  • I tested this: Checked builds correctly in sandbox
  • I read through the code

@bradenmacdonald
bradenmacdonald merged commit f79b65c into openedx:master Sep 2, 2025
7 checks passed
@github-project-automation github-project-automation Bot moved this from Waiting on Author to Done in Contributions Sep 2, 2025
@bradenmacdonald
bradenmacdonald deleted the samuel/update-frontend-build branch September 2, 2025 16:48
@samuelallan72 samuelallan72 changed the title fix: update frontend-build to fix install issues fix: update frontend-build to fix install issues (FC-0094) Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Update sharp dependency

6 participants