fix: update frontend-build to fix install issues (FC-0094) - #2387
Conversation
|
Thanks for the pull request, @samuelallan72! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Sandbox deployment failed 💥 |
1 similar comment
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
1 similar comment
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2387 +/- ##
========================================
Coverage 94.60% 94.60%
========================================
Files 1179 1179
Lines 25506 25506
Branches 5449 5591 +142
========================================
Hits 24129 24129
+ Misses 1314 1309 -5
- Partials 63 68 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sandbox deployment successful 🚀 |
580ad37 to
ec160d3
Compare
ec160d3 to
52952f7
Compare
Earlier versions of @openedx/frontend-build used on older version of 'sharp', which caused intermittent installation issues. The version of 'sharp' was updated in @openedx/frontend-build to fix these issues, so the frontend-build version can be updated here, to fix the issues in this project too. See openedx/frontend-build#664 and openedx/frontend-build#665 for more information. The frontend-build dependency was updated by: ``` npm install --package-lock-only @openedx/frontend-build ``` Private-ref: https://tasks.opencraft.com/browse/BB-9953
52952f7 to
68f57cb
Compare
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
|
LGTM 👍
|
Description
Earlier versions of @openedx/frontend-build used on older version of 'sharp', which caused intermittent installation issues. The version of 'sharp' was updated in @openedx/frontend-build to fix these issues, so the frontend-build version can be updated here, to fix the issues in this project too. See openedx/frontend-build#664 (issue) and openedx/frontend-build#665 (PR) for more information.
The frontend-build dependency was updated by:
Supporting information
Private-ref: https://tasks.opencraft.com/browse/BB-9953
Testing instructions
npm cito install dependenciesOther information
N/A