Improved taxonomy badges - #3125
Conversation
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
There is a similar/same ticket to do this here - we need to make sure we align on a unified design choice: openedx/openedx-core#616 |
|
What is the full list of possible metadata that could be included here? |
|
|
@edschema @jmakowski1123 Could you let me know how you'd like this to move forward? |

Description
This is a proposal (and WIP implementation - still needs polish and tests) to improve the display of the taxonomies list, based on the current properties of taxonomies in the system today.
Before
After
Notes
There are no changes to the backend; this just updates the UI to:
Disabled taxonomy:
Note that "Disabled" now shows in the UI, whereas before there would be no indication why this taxonomy appears normal on this page, but is hidden everywhere else.
Testing instructions
View the taxonomy list page. Use the Django admin to change the advanced settings of taxonomies and see the labels change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'