Skip to content

[FC-0036] feat: Send messages after update tags - #975

Merged
xitij2000 merged 1 commit into
openedx:masterfrom
open-craft:chris/update-tags-count
May 3, 2024
Merged

[FC-0036] feat: Send messages after update tags#975
xitij2000 merged 1 commit into
openedx:masterfrom
open-craft:chris/update-tags-count

Conversation

@ChrisChV

@ChrisChV ChrisChV commented May 2, 2024

Copy link
Copy Markdown
Contributor

Description

Updates the code of Tag Drawer to send two messages to parent (if the drawer is a iframe) when the tags are updated:

  • One message with updated content tags.
  • One message with the content tags count.

Supporting information

Testing instructions

* One message with new content tags
* One message with the tag count
@ChrisChV
ChrisChV requested a review from a team as a code owner May 2, 2024 15:43
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 2, 2024
@openedx-webhooks

openedx-webhooks commented May 2, 2024

Copy link
Copy Markdown

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@ChrisChV
ChrisChV marked this pull request as draft May 2, 2024 15:43
@codecov

codecov Bot commented May 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.20%. Comparing base (65f45f7) to head (2c86066).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #975   +/-   ##
=======================================
  Coverage   92.20%   92.20%           
=======================================
  Files         703      703           
  Lines       12334    12334           
  Branches     2671     2667    -4     
=======================================
  Hits        11372    11372           
  Misses        926      926           
  Partials       36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisChV ChrisChV changed the title feat: Send messages after update tags [FC-0036] feat: Send messages after update tags May 2, 2024
@ChrisChV
ChrisChV marked this pull request as ready for review May 2, 2024 16:55

@yusuf-musleh yusuf-musleh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 @ChrisChV Looks good!

  • I tested this: I followed the testing instructions openedx/openedx-platform#34682
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@xitij2000 xitij2000 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a test here would have been nice but I guess it's very temporary code.

@ChrisChV

ChrisChV commented May 3, 2024

Copy link
Copy Markdown
Contributor Author

I think a test here would have been nice but I guess it's very temporary code.

@xitij2000 Yes, I have not do a test for this task because it is temporary and urgent. It's ready to merge

@xitij2000
xitij2000 merged commit 64be7e3 into openedx:master May 3, 2024
@openedx-webhooks

Copy link
Copy Markdown

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@xitij2000
xitij2000 deleted the chris/update-tags-count branch May 3, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants