build: Upgrade to Node 24 - #702
Conversation
|
Thanks for the pull request, @PKulkoRaccoonGang! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
openedx-webhooks
added
the
open-source-contribution
043a989 to
e58b9c7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
=======================================
Coverage 97.60% 97.60%
=======================================
Files 152 152
Lines 1334 1334
Branches 231 231
=======================================
Hits 1302 1302
Misses 31 31
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e58b9c7 to
403add5
Compare
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
[inform]: The addition of tsconfig.json is caused by an error when importing the TS file from the header.
Module './StudioHeader' was resolved to '/Users/peterkulko/dev/tutor_workspaces/tutor-oex-main/src/frontend-app-learner-dashboard/node_modules/@edx/frontend-component-header/dist/studio-header/StudioHeader.tsx', but '--jsx' is not set.
There was a problem hiding this comment.
This answers a question I had about a different PR that did the same thing. Thanks for clearing it up. :)
itsjeyd
added
blocked by other work
403add5 to
1d4d5d5
Compare
arbrandes
left a comment
arbrandes
left a comment
There was a problem hiding this comment.
For now this is neither an approval or disapproval, but I did have an inline question.
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
This answers a question I had about a different PR that did the same thing. Thanks for clearing it up. :)
| id: 'learner-dash.unenrollConfirm.confirm.reason.heading', | ||
| description: 'Heading for unenroll reason modal', | ||
| defaultMessage: 'Why are you unenrolling?', | ||
| defaultMessage: 'What\'s your main reason for unenrolling?', |
There was a problem hiding this comment.
Out of curiosity: was this necessary for the Node 24 upgrade?
There was a problem hiding this comment.
Hmm, I don't remember why this was added to this PR request. It's superfluous, I removed it.
itsjeyd
added
waiting on author
|
this looks good to me, merging. |
openedx-webhooks
removed
the
waiting on author
5 participants
Description
As a second step in the Node 24 upgrade process, upgrade
.nvmrcand regeneratepackage-lock.jsonfrom scratch using Node 24. Also make the Node 24 test a blocking one.See the tracking issue for futher information.