Skip to content

Removing '-1 +' from media queries - #1727

Merged
bradenmacdonald merged 2 commits into
openedx:masterfrom
jacobo-dominguez-wgu:eat/1701-removing-1+
Jun 4, 2025
Merged

Removing '-1 +' from media queries#1727
bradenmacdonald merged 2 commits into
openedx:masterfrom
jacobo-dominguez-wgu:eat/1701-removing-1+

Conversation

@jacobo-dominguez-wgu

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

Description

Removing -1 + from media queries on css files since it does not affect the display.
All removals were verified and they do not represent any visual difference on the rendered screen.
Issue: #1701

Screenshots for before and after

Captura de pantalla 2025-06-04 a la(s) 1 25 45 p m Captura de pantalla 2025-06-04 a la(s) 1 26 18 p m
Captura de pantalla 2025-06-04 a la(s) 12 20 17 p m Captura de pantalla 2025-06-04 a la(s) 12 22 34 p m
Captura de pantalla 2025-06-04 a la(s) 12 32 54 p m Captura de pantalla 2025-06-04 a la(s) 12 34 26 p m
Captura de pantalla 2025-06-04 a la(s) 12 42 38 p m Captura de pantalla 2025-06-04 a la(s) 12 43 41 p m
Captura de pantalla 2025-06-04 a la(s) 1 12 14 p m Captura de pantalla 2025-06-04 a la(s) 1 13 12 p m
Captura de pantalla 2025-06-04 a la(s) 1 14 41 p m Captura de pantalla 2025-06-04 a la(s) 1 16 12 p m

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 4, 2025
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@jacobo-dominguez-wgu jacobo-dominguez-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Jun 4, 2025
@codecov

codecov Bot commented Jun 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.45%. Comparing base (d1dede5) to head (18e537b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1727   +/-   ##
=======================================
  Coverage   90.45%   90.45%           
=======================================
  Files         344      344           
  Lines        5802     5802           
  Branches     1395     1398    +3     
=======================================
  Hits         5248     5248           
  Misses        535      535           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobo-dominguez-wgu jacobo-dominguez-wgu moved this from Needs Triage to Ready for Review in Contributions Jun 4, 2025
@jacobo-dominguez-wgu
jacobo-dominguez-wgu requested a review from a team June 4, 2025 20:20
@jacobo-dominguez-wgu jacobo-dominguez-wgu changed the title feat: removing '-1 +' from media queries Removing '-1 +' from media queries Jun 4, 2025

@wgu-jesse-stewart wgu-jesse-stewart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bradenmacdonald
bradenmacdonald merged commit 7edac93 into openedx:master Jun 4, 2025
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants