Skip to content

feat: Add new slots for customizing course outline section and sequence completion icons - #1933

Merged
brian-smith-tcril merged 5 commits into
openedx:masterfrom
open-craft:kshitij/course-outline-slots
Jul 17, 2026
Merged

feat: Add new slots for customizing course outline section and sequence completion icons#1933
brian-smith-tcril merged 5 commits into
openedx:masterfrom
open-craft:kshitij/course-outline-slots

Conversation

@xitij2000

Copy link
Copy Markdown
Contributor

Introduces CourseOutlineSidebarSectionCompletionIconSlot and CourseOutlineSidebarSequenceCompletionIconSlot to enable customization, modification, or replacement of completion icons in the course outline. Updated components to integrate with these new slots.

…ce completion icons

Introduces `CourseOutlineSidebarSectionCompletionIconSlot` and `CourseOutlineSidebarSequenceCompletionIconSlot` to enable customization, modification, or replacement of completion icons in the course outline. Updated components to integrate with these new slots.
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @xitij2000!

This repository is currently maintained by @openedx/committers-frontend-app-learning.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 20, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 20, 2026
@xitij2000
xitij2000 force-pushed the kshitij/course-outline-slots branch from f17717e to 9062e5a Compare June 22, 2026 08:29
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.46%. Comparing base (6f1dfbb) to head (803dec5).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1933      +/-   ##
==========================================
+ Coverage   91.30%   91.46%   +0.15%     
==========================================
  Files         346      351       +5     
  Lines        5776     5820      +44     
  Branches     1350     1393      +43     
==========================================
+ Hits         5274     5323      +49     
+ Misses        483      478       -5     
  Partials       19       19              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@itsjeyd itsjeyd moved this from Needs Triage to Ready for Review in Contributions Jun 24, 2026
@itsjeyd itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jun 24, 2026
Updated `CourseOutlineSidebarSectionCompletionIconSlot` and `CourseOutlineSidebarSequenceCompletionIconSlot` to include an `active` prop, enabling styling based on the active state of sections or sequences.
Combined `CourseOutlineSidebarSectionCompletionIconSlot` and `CourseOutlineSidebarSequenceCompletionIconSlot` into a single `CourseOutlineSidebarCompletionIconSlot` to simplify implementation. Updated components to use the `variant` prop for distinguishing between sections and sequences.docs: Add README for `CourseOutlineSidebarCompletionIconSlot`

Introduced documentation for the consolidated `CourseOutlineSidebarCompletionIconSlot`, including usage examples for customizing section and sequence completion icons.

@brian-smith-tcril brian-smith-tcril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is looking good! I left a couple comments with questions and notes. Looking forward to seeing this come together!

Comment thread src/plugin-slots/CourseOutlineSidebarCompletionIconSlot/README.md Outdated
Comment thread src/plugin-slots/CourseOutlineSidebarCompletionIconSlot/README.md Outdated
Comment thread src/courseware/course/sidebar/sidebars/course-outline/CourseOutline.tsx Outdated
@brian-smith-tcril

Copy link
Copy Markdown
Contributor

@xitij2000 it looks like CI is failing on lint errors

@itsjeyd itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Jul 13, 2026
@itsjeyd itsjeyd moved this from Ready for Review to In Eng Review in Contributions Jul 13, 2026
@xitij2000
xitij2000 force-pushed the kshitij/course-outline-slots branch from 0a14b1d to 803dec5 Compare July 14, 2026 04:15
@xitij2000

Copy link
Copy Markdown
Contributor Author

@brian-smith-tcril Just fixed.

@brian-smith-tcril brian-smith-tcril left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this with me!

@brian-smith-tcril
brian-smith-tcril merged commit 8eb7cca into openedx:master Jul 17, 2026
7 checks passed
@openedx-webhooks openedx-webhooks removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jul 17, 2026
@github-project-automation github-project-automation Bot moved this from In Eng Review to Done in Contributions Jul 17, 2026
@xitij2000
xitij2000 deleted the kshitij/course-outline-slots branch July 17, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants