fix: use new xblock handler URLs for sequence blocks - #423
Conversation
Dillon-Dumesnil
left a comment
Dillon-Dumesnil
left a comment
There was a problem hiding this comment.
Subject to approval of the backend, but all these changes look good.
| export async function getBlockCompletion(courseId, sequenceId, usageKey) { | ||
| // Post data sent to this endpoint must be url encoded | ||
| // TODO: Remove the need for this to be the case. | ||
| // TODO: Ensure this usage of URLSearchParams is working in Internet Explorer |
There was a problem hiding this comment.
... Wonder whatever happened here.
| urlEncoded.toString(), | ||
| requestConfig, | ||
| `${getSequenceHandlerUrl(courseId, sequenceId)}/goto_position`, | ||
| // Position is 1-indexed on the server and 0-indexed in this app. Adjust here. |
MatthewPiatetsky
left a comment
MatthewPiatetsky
left a comment
There was a problem hiding this comment.
were you able to test this locally?
Yeah with the new backend, both master and this PR worked as expected (master had the bug but was able to call old handlers fine, this PR called new fixed handlers). But this needs the new backend code to be in prod first. |
They've changed to proper new-style handlers, so the URL also changed. This will let us get the fix for green checkmarks showing up as audit users pass FBE units, even though those units aren't actually complete. AA-409
b3415de to
32b586b
Compare
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 82.39% 82.37% -0.02%
==========================================
Files 195 195
Lines 3113 3104 -9
Branches 774 773 -1
==========================================
- Hits 2565 2557 -8
+ Misses 532 531 -1
Partials 16 16
Continue to review full report at Codecov.
|
3 participants
They've changed to proper new-style handlers, so the URL also changed. This will let us get the fix for green checkmarks showing up as audit users pass FBE units, even though those units aren't actually complete.
https://openedx.atlassian.net/browse/AA-409
https://github.com/edx/edx-platform/pull/27422