fix: disable dot rule in historyApiFallback in webpack.dev.config.js files.#352
Merged
Conversation
brobro10000
approved these changes
May 2, 2023
ghost
approved these changes
May 2, 2023
3 tasks
|
🎉 This PR is included in version 12.8.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
muselesscreator
pushed a commit
that referenced
this pull request
Aug 1, 2023
muselesscreator
pushed a commit
that referenced
this pull request
Aug 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this issue trying to use an MFE route that contains a course key with a period (e.g.,
MITx+CTL.SC2x) in two different MFEs relying on standard development webpack configs from@edx/frontend-build:This PR sets
disableDotRule: truefor thehistoryApiFallbackconfiguration to make it possible to load MFE routes with a period (.) in them without issue.Docs: https://github.com/bripkens/connect-history-api-fallback#disabledotrule