Skip to content

FC-0001: Account pages -> micro-frontend - #210

Merged
arbrandes merged 1 commit into
openedx:masterfrom
raccoongang:depr/account-pages
Dec 2, 2022
Merged

FC-0001: Account pages -> micro-frontend#210
arbrandes merged 1 commit into
openedx:masterfrom
raccoongang:depr/account-pages

Conversation

@UvgenGen

@UvgenGen UvgenGen commented May 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description:

Added ACCOUNT_PROFILE_URL and ACCOUNT_SETTINGS_URL settings.

edx-platform PR: openedx/openedx-platform#30336
frontend-platform PR: openedx/frontend-platform#326

Supporting information

openedx/public-engineering#71
Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-17

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 2, 2022
@openedx-webhooks

openedx-webhooks commented May 2, 2022

Copy link
Copy Markdown

Thanks for the pull request, @UvgenGen! I've created OSPR-6653 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

This was referenced May 2, 2022
Merged
Merged
@openedx-webhooks openedx-webhooks added awaiting prioritization waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs triage awaiting prioritization labels May 3, 2022
@natabene

natabene commented May 3, 2022

Copy link
Copy Markdown

@UvgenGen Could you look into the failing CI test?

@UvgenGen
UvgenGen force-pushed the depr/account-pages branch from 948386f to ef94583 Compare May 5, 2022 15:43
@UvgenGen

UvgenGen commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

@natabene Linter error fixed.

@natabene

natabene commented May 6, 2022

Copy link
Copy Markdown

@UvgenGen Let's see how tests turn out.

@codecov

codecov Bot commented May 6, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #210 (ef94583) into master (48c41a7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   62.58%   62.58%           
=======================================
  Files          15       15           
  Lines         278      278           
  Branches       66       66           
=======================================
  Hits          174      174           
  Misses        103      103           
  Partials        1        1
Impacted Files Coverage Δ
src/Header.jsx 89.47% <ø> (ø)
src/learning-header/AuthenticatedUserDropdown.jsx 83.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c41a7...ef94583. Read the comment docs.

@natabene

natabene commented May 6, 2022

Copy link
Copy Markdown

@arbrandes This is ready for your review.

@openedx-webhooks openedx-webhooks added engineering review and removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. labels May 6, 2022
@arbrandes arbrandes self-assigned this Jun 7, 2022
abdullahwaheed
abdullahwaheed approved these changes Oct 12, 2022
View reviewed changes

@abdullahwaheed abdullahwaheed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with respective changes of frontend-platform. I think we can merge it

@arbrandes
arbrandes self-requested a review October 12, 2022 13:28
@arbrandes arbrandes removed their assignment Oct 17, 2022
@arbrandes arbrandes mentioned this pull request Oct 17, 2022
Closed
27 tasks
@arbrandes arbrandes linked an issue Oct 18, 2022 that may be closed by this pull request
[DEPR]: Account pages -> micro-frontend openedx/public-engineering#71
Closed
@arbrandes arbrandes mentioned this pull request Oct 31, 2022
Closed
30 tasks
@arbrandes arbrandes mentioned this pull request Nov 14, 2022
Closed
36 tasks
@arbrandes arbrandes mentioned this pull request Nov 29, 2022
Closed
28 tasks
@arbrandes
arbrandes merged commit 5ee8a8c into openedx:master Dec 2, 2022
@openedx-webhooks

openedx-webhooks commented Dec 2, 2022

Copy link
Copy Markdown

@UvgenGen 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

ghassanmas added a commit to ghassanmas/tutor-mfe that referenced this pull request Apr 25, 2023
@ghassanmas
fix: Add account url in dynamic config
d09e411 
   frontend-component-header since version v.3.5 requires the
   the settings of ACCOUNT_SETTINGS_URL to exists as it uses
   it point to the account MFE.
   - openedx/frontend-component-header/pull/210 PR that
   add the setting the componenet
   - openedx/wg-build-test-release/issues/268 which this fixes
@ghassanmas ghassanmas mentioned this pull request Apr 25, 2023
Merged
ghassanmas added a commit to ghassanmas/tutor-mfe that referenced this pull request May 16, 2023
@ghassanmas
fix: Add account url in dynamic config
8a2ccc0 
   frontend-component-header since version v.3.5 requires the
   the settings of ACCOUNT_SETTINGS_URL to exists as it uses
   it point to the account MFE.
   - openedx/frontend-component-header/pull/210 PR that
   add the setting the componenet
   - openedx/wg-build-test-release/issues/268 which this fixes
ghassanmas added a commit to ghassanmas/tutor-mfe that referenced this pull request May 17, 2023
@ghassanmas
fix: Add account url in dynamic config
652e582 
   frontend-component-header since version v.3.5 requires the
   the settings of ACCOUNT_SETTINGS_URL to exists as it uses
   it point to the account MFE.
   - openedx/frontend-component-header/pull/210 PR that
   add the setting the componenet
   - openedx/wg-build-test-release/issues/268 which this fixes
ghassanmas added a commit to ghassanmas/tutor-mfe that referenced this pull request May 17, 2023
@ghassanmas
fix: Add account url in dynamic config
7713864 
   frontend-component-header since version v.3.5 requires the
   the settings of ACCOUNT_SETTINGS_URL to exists as it uses
   it point to the account MFE.
   - openedx/frontend-component-header/pull/210 PR that
   add the setting the componenet
   - openedx/wg-build-test-release/issues/268 which this fixes
arbrandes pushed a commit to overhangio/tutor-mfe that referenced this pull request May 18, 2023
@ghassanmas @arbrandes
fix: Add account url in dynamic config
2b9d23e 
   frontend-component-header since version v.3.5 requires the
   the settings of ACCOUNT_SETTINGS_URL to exists as it uses
   it point to the account MFE.
   - openedx/frontend-component-header/pull/210 PR that
   add the setting the componenet
   - openedx/wg-build-test-release/issues/268 which this fixes
@Mashal-m Mashal-m mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arbrandes arbrandes arbrandes approved these changes
+2 more reviewers
@abdullahwaheed abdullahwaheed abdullahwaheed approved these changes
@BilalQamar95 BilalQamar95 BilalQamar95 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Contributions
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[DEPR]: Account pages -> micro-frontend

6 participants

@UvgenGen @openedx-webhooks @natabene @arbrandes @abdullahwaheed @BilalQamar95