feat: delete old videos Directory - #316
Closed
omerhabib26 wants to merge 0 commit into
Closed
Conversation
HamzaIsrar12
requested changes
May 10, 2024
HamzaIsrar12
left a comment
HamzaIsrar12
left a comment
Contributor
There was a problem hiding this comment.
Test cases are failing.
Contributor
|
Test Cases are still failing ... |
omerhabib26
force-pushed
the
omer/LEARNER-9950
branch
from
May 16, 2024 20:02
b9fcf8c to
29b3fd0
Compare
Contributor
Author
|
@volodymyr-chekyrta, @k1rill please spare some time to review this PR. |
HamzaIsrar12
previously approved these changes
May 21, 2024
Comment on lines
+139
to
+142
| if (viewModel.canResetAppDirectory){ | ||
| viewModel.resetAppDirectory(this) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
What if we just encapsulate all this inside of the AppViewModel#onCreate?
In this case, we would remove the extra variable and this logic from the view.
Contributor
Author
There was a problem hiding this comment.
sure, I'll update it accordingly.
Contributor
Author
|
Test cases are failing due to context, the issue is already addressed in PR-308. I'll update and merge it once PR-308 is merged. |
volodymyr-chekyrta
previously approved these changes
May 23, 2024
volodymyr-chekyrta
left a comment
volodymyr-chekyrta
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
Let's merge it after the #308
omerhabib26
force-pushed
the
omer/LEARNER-9950
branch
from
May 30, 2024 09:37
5f65522 to
0d093ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements functionality to delete outdated video files stored in the previous app directory upon the first launch of the updated app version. This ensures that storage is efficiently managed, preventing unnecessary space usage by obsolete files, and maintaining consistency with the new data storage structure.
fix: LEARNER-9950