Skip to content

fix: issue to load the video through chrome-cast device #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volodymyr-chekyrta merged 1 commit into from
Apr 7, 2025
Merged

fix: issue to load the video through chrome-cast device #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions course/src/main/java/org/openedx/course/presentation/unit/video/EncodedVideoUnitViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ class EncodedVideoUnitViewModel(
CastContext.getSharedInstance(context, executor).addOnCompleteListener {
it.result?.let { castContext ->
castPlayer = CastPlayer(castContext)
isUpdatedMutable.value = true
}
}
}
Expand Down
8 changes: 4 additions & 4 deletions course/src/main/java/org/openedx/course/presentation/unit/video/VideoUnitViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ open class VideoUnitViewModel(
val currentVideoTime: LiveData<Long>
get() = _currentVideoTime

private val _isUpdated = MutableLiveData(true)
protected val isUpdatedMutable = MutableLiveData(true)
val isUpdated: LiveData<Boolean>
get() = _isUpdated
get() = isUpdatedMutable

private val _currentIndex = MutableStateFlow(0)
val currentIndex = _currentIndex.asStateFlow()
Expand All @@ -63,9 +63,9 @@ open class VideoUnitViewModel(
viewModelScope.launch {
notifier.notifier.collect {
if (it is CourseVideoPositionChanged && videoUrl == it.videoUrl) {
_isUpdated.value = false
isUpdatedMutable.value = false
_currentVideoTime.value = it.videoTime
_isUpdated.value = true
isUpdatedMutable.value = true
isPlaying = it.isPlaying
} else if (it is CourseSubtitleLanguageChanged) {
transcriptLanguage = it.value
Expand Down