Skip to content

feat: Add Token Refresh Implementation to Network Layer - #84

Merged
volodymyr-chekyrta merged 2 commits into
openedx:developfrom
HamzaIsrar12:hamza/token_refresh_mech
Nov 22, 2023
Merged

feat: Add Token Refresh Implementation to Network Layer#84
volodymyr-chekyrta merged 2 commits into
openedx:developfrom
HamzaIsrar12:hamza/token_refresh_mech

Conversation

@HamzaIsrar12

@HamzaIsrar12 HamzaIsrar12 commented Nov 4, 2023

Copy link
Copy Markdown
Contributor

It applies token authentication to the network requests before a network call is made. The expiry duration is saved and it is applied before a network request is queued.

Authentication:

  • Token authentication before a network request
  • Refresh expired token before making a network request
  • Only one token refresh call for all async network requests
  • Only one token refresh call for all sync network requests
  • No looping of network calls during network problem

@volodymyr-chekyrta

Copy link
Copy Markdown
Contributor

It's confusing that all the work here with time is done in seconds.
It seems easier and clearer to convert authResponse.expiresIn to milliseconds and work with them.

k1rill
k1rill previously approved these changes Nov 21, 2023
It applies token authentication to the network requests before a
network call is made. The expiry duration is saved and it is
applied before a network request is queued.
@volodymyr-chekyrta
volodymyr-chekyrta merged commit d1bf1a6 into openedx:develop Nov 22, 2023
@HamzaIsrar12
HamzaIsrar12 deleted the hamza/token_refresh_mech branch January 1, 2024 07:33
@HamzaIsrar12 HamzaIsrar12 linked an issue May 6, 2024 that may be closed by this pull request
farhan-arshad-dev pushed a commit to farhan-arshad-dev/openedx-app-android that referenced this pull request Jul 9, 2025
…x#84)

- Allows users to move from the NotificationsInbox screen to the Discussion component

fix: LEARNER-10373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Android] Acess Token Refresh Mechanism

3 participants