fix: fix coredata crash on primary course - #518
Merged
volodymyr-chekyrta merged 1 commit intoSep 30, 2024
Conversation
rnr
changed the title
volodymyr-chekyrta
approved these changes
Sep 6, 2024
volodymyr-chekyrta
left a comment
volodymyr-chekyrta
left a comment
Contributor
There was a problem hiding this comment.
LGTM 👍
The best way to handle this would probably be to convert it to an async await function, but we can do that later for the whole class.
IvanStepanok
pushed a commit
to raccoongang/openedx-app-ios
that referenced
this pull request
Sep 1, 2025
Co-authored-by: Saeed Bashir <sbashir@2u.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the crash with coredata. Although, I'm not able to reproduce the crash but from dry run it it can occur because of deleting the data async and right before saving new data and expecting the data will be deleted.
Crash Link: https://console.firebase.google.com/u/1/project/openedx-mobile/crashlytics/app/ios:org.edx.mobile/issues/cb09ae273338d6fa32acb9f64effefbf?time=last-seven-days&types=crash&versions=6.0.0%20(2)&sessionEventKey=f4c972ede3fd4c18901af18a71e6b702_1979319760445579771