Skip to content

fix: first batch of fix PRs to synchronise with upstream - #526

Merged
volodymyr-chekyrta merged 10 commits into
openedx:developfrom
edx:portion-1-sync-to-upstream
Oct 8, 2024
Merged

fix: first batch of fix PRs to synchronise with upstream#526
volodymyr-chekyrta merged 10 commits into
openedx:developfrom
edx:portion-1-sync-to-upstream

Conversation

@rnr

@rnr rnr commented Oct 7, 2024

Copy link
Copy Markdown
Contributor

This batch contains next fixes:

  1. Fix for delete remaining tmp files when cancel video download - fix: fixes for downloading edx/edx-mobile-marketplace-ios#23
  2. When open Course "Home" tab, a list of course sections is shown but over time, the height of the cells increases -
    fix: [iOS] On Course "Home" tab the row height edx/edx-mobile-marketplace-ios#24
  3. UI improvement for Primary Card Landscape - feat: Landscape mode Improvement edx/edx-mobile-marketplace-ios#25
  4. Don’t show the error snack bar on the failure of API /api/course_experience/v1/course_deadlines_info/ - chore: remove snack bar error for course dates info API on course home edx/edx-mobile-marketplace-ios#27
  5. Course Level Error Handling for Empty States - feat: Course Level Error Handling for Empty States edx/edx-mobile-marketplace-ios#28

@rnr
rnr requested a review from volodymyr-chekyrta October 7, 2024 11:48

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@volodymyr-chekyrta
volodymyr-chekyrta merged commit 004666e into openedx:develop Oct 8, 2024
@rnr
rnr deleted the portion-1-sync-to-upstream branch November 22, 2024 12:52
IvanStepanok pushed a commit to raccoongang/openedx-app-ios that referenced this pull request Sep 1, 2025
* Merge pull request openedx#23 from edx/small-fix-for-downloading-cancelling

fix: fixes for downloading

* chore: fix for Xcode 16 and after merge

* Merge pull request openedx#24 from edx/2U/fix/download-states

fix: [iOS] On Course "Home" tab the row height

* fix: after merge, deleted IAP part

fix: [iOS] On Course "Home" tab the row height

* Merge pull request openedx#25 from edx/2U/feat/primary-horizontal

feat: Landscape mode Improvement

* fix: removed IAP part

* chore: remove snack bar error for course dates info API on course home (openedx#27)

* Merge pull request openedx#28 from shafqat-muneer/Shafqat/LEARNER-10020-ErrorHandling

feat: Course Level Error Handling for Empty States

* chore: remove IAP part after merging

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
Co-authored-by: Saeed Bashir <sbashir@2u.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants