Skip to content

fix: Part 5 sync to upstream - #542

Merged
volodymyr-chekyrta merged 9 commits into
openedx:developfrom
edx:part-5-sync-to-upstream
Nov 18, 2024
Merged

fix: Part 5 sync to upstream#542
volodymyr-chekyrta merged 9 commits into
openedx:developfrom
edx:part-5-sync-to-upstream

Conversation

@rnr

@rnr rnr commented Nov 11, 2024

Copy link
Copy Markdown
Contributor

This sync PR contains next fixes:

  1. Add eye icon for password field feat: eye icon for password field edx/edx-mobile-marketplace-ios#42
Screenshot 2024-11-11 at 11 29 55
  1. Clear cookies by logout to fix Register experience fix: clear cookies by logout edx/edx-mobile-marketplace-ios#44
  2. UI fix: reduce grid spacing style: reduce grid spacing edx/edx-mobile-marketplace-ios#47
Screenshot 2024-11-11 at 11 26 34
  1. UI fix for Alert’s Title truncation chore: Fix outdated course dates alert title truncation issue edx/edx-mobile-marketplace-ios#53
Screenshot 2024-11-11 at 11 27 28
  1. Videos Tab: Show downloading video size in Mb or Gb chore: size in GB or MB edx/edx-mobile-marketplace-ios#57
  2. Remove urls from headings of End User license agreements fix: Remove urls from headings of End User lisence agreements edx/edx-mobile-marketplace-ios#65

@volodymyr-chekyrta volodymyr-chekyrta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@volodymyr-chekyrta
volodymyr-chekyrta merged commit f209262 into openedx:develop Nov 18, 2024
@rnr
rnr deleted the part-5-sync-to-upstream branch November 22, 2024 12:53
IvanStepanok pushed a commit to raccoongang/openedx-app-ios that referenced this pull request Sep 1, 2025
* Merge pull request openedx#42 from edx/password-input-view-eye

feat: eye icon for password field

* chore: added SecureInputView to project

* Merge pull request openedx#44 from edx/clear-cookies-by-logout

fix: clear cookies by logout

* Merge pull request openedx#47 from edx/reduce-grid-spacing

style: reduce grid spacing

* chore: Fix outdated course dates alert title truncation issue (openedx#53)

* Merge pull request openedx#57 from edx/remaining-size-in-gb-or-mb

chore: size in GB or MB

* fix: Remove urls from headings of End User lisence agreements (openedx#65)

* fix: move padding to right place

* chore: fixed double space

---------

Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com>
Co-authored-by: Shafqat Muneer <smuneer@2u.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants