Codestyle improvements - #76
Merged
Merged
Conversation
IvanStepanok
approved these changes
Sep 15, 2023
volodymyr-chekyrta
added a commit
that referenced
this pull request
Sep 22, 2023
* bug fix (#57) * Fix DisclosureGroup fields bug on SignUpView (#58) * Hide no discussion while update (#59) * Consolidating Databases and Refactoring Module Logic (#60) This merge request aims to consolidate multiple databases into a single one for improved efficiency and maintainability in the OpenEdx project. The changes involve creating a new class, DatabaseManager, which handles CoreData operations and moving CoreData logic from specific modules to this central manager. Additionally, a new method, deleteAllFiles(), is added to the DownloadManager class for convenient file deletion upon user logout. * Migrate all colors to Theme (#61) * Added support for multiple color schemes to quickly switch between educational platforms. Updated variables throughout the project accordingly. * Fix not updating completion error (#64) completion doesn't update status when user has finished learning the contents of a unit * Remove custom navigation controller (#63) * Remove custom navigation controller Change navigation controller from custom to system for feature changes and adding possibility to swipe gestures * disable routing whenever handouts is empty (#66) * Fix the isMobileData variable in the Connectivity module. (#67) Add the possibility to play videos with sound in silent mode. * encoded video dissmiss by device rotation (#68) * fixed * Separate AppStorage to protocol oriented architecture. (#69) * Separate AppStorage to protocol oriented architecture. * Added path field to the DownloadData model. (#70) * Added path field to the DownloadData model. All control over files was refactored using the new path field. * Fix CourseContainerViewModelTests * September bugfixes (#71) * fix incorrect back button on the course screen * Fix issue on Delete account view. The inactive button is clickable. * change CourseDetailsEndpoint to CourseEndpoint fix WebView bug with iframe fix doubling courses on Dashboard after subscribe to a new course * Create 0001-strategy-for-maintaining-OS-versions.rst (#72) * Create 0001-strategy-for-maintaining-OS-versions.rst * Update 0001-strategy-for-maintaining-OS-versions.rst * Deprecate iOS 14 (#74) * Deprecate iOS 14 Remove isIOS14 in ViewExtension Change deployment target to iOS 15 Add a new RefreshableScrollView for better pull to refresh animation on any iOS update loading logic in DiscoveryViewModel, ThreadViewModel, and PostsViewModel for a smooth refreshing * Update refreshable ScrollView to native for iOS 16+ (#75) * Update refreshable ScrollView to native for iOS 16+ * Codestyle improvements (#76) * codestyle improvements * remove unused code * ios 17 bugfixes (#77) * bugfixes * Change license to Apache (#78) --------- Co-authored-by: IvanStepanok <128456094+IvanStepanok@users.noreply.github.com>
volodymyr-chekyrta
pushed a commit
that referenced
this pull request
Dec 9, 2024
* fix: video tab with youtube (#52) * fix: don't show error if only youtube videos * fix: call UI updates from main queue * fix: don't send completion at youtube video start --------- Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com> * chore: delete unneeded MainActor instructions * feat: save playback speed (#67) * chore: save playback speed in CourseStorage * chore: add full screen for youtube on iPad * chore: save value in userdefaults * chore: little refactor * fix: fix warning * chore: added CourseStorage as injection * chore: moved playback speed to user settings --------- Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com> * chore: analytics screen events improvements and name fixes (#76) * chore: fix tests --------- Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com> Co-authored-by: Saeed Bashir <sbashir@2u.com>
IvanStepanok
pushed a commit
to raccoongang/openedx-app-ios
that referenced
this pull request
Sep 1, 2025
* codestyle improvements * remove unused code
IvanStepanok
added a commit
to raccoongang/openedx-app-ios
that referenced
this pull request
Sep 1, 2025
* bug fix (openedx#57) * Fix DisclosureGroup fields bug on SignUpView (openedx#58) * Hide no discussion while update (openedx#59) * Consolidating Databases and Refactoring Module Logic (openedx#60) This merge request aims to consolidate multiple databases into a single one for improved efficiency and maintainability in the OpenEdx project. The changes involve creating a new class, DatabaseManager, which handles CoreData operations and moving CoreData logic from specific modules to this central manager. Additionally, a new method, deleteAllFiles(), is added to the DownloadManager class for convenient file deletion upon user logout. * Migrate all colors to Theme (openedx#61) * Added support for multiple color schemes to quickly switch between educational platforms. Updated variables throughout the project accordingly. * Fix not updating completion error (openedx#64) completion doesn't update status when user has finished learning the contents of a unit * Remove custom navigation controller (openedx#63) * Remove custom navigation controller Change navigation controller from custom to system for feature changes and adding possibility to swipe gestures * disable routing whenever handouts is empty (openedx#66) * Fix the isMobileData variable in the Connectivity module. (openedx#67) Add the possibility to play videos with sound in silent mode. * encoded video dissmiss by device rotation (openedx#68) * fixed * Separate AppStorage to protocol oriented architecture. (openedx#69) * Separate AppStorage to protocol oriented architecture. * Added path field to the DownloadData model. (openedx#70) * Added path field to the DownloadData model. All control over files was refactored using the new path field. * Fix CourseContainerViewModelTests * September bugfixes (openedx#71) * fix incorrect back button on the course screen * Fix issue on Delete account view. The inactive button is clickable. * change CourseDetailsEndpoint to CourseEndpoint fix WebView bug with iframe fix doubling courses on Dashboard after subscribe to a new course * Create 0001-strategy-for-maintaining-OS-versions.rst (openedx#72) * Create 0001-strategy-for-maintaining-OS-versions.rst * Update 0001-strategy-for-maintaining-OS-versions.rst * Deprecate iOS 14 (openedx#74) * Deprecate iOS 14 Remove isIOS14 in ViewExtension Change deployment target to iOS 15 Add a new RefreshableScrollView for better pull to refresh animation on any iOS update loading logic in DiscoveryViewModel, ThreadViewModel, and PostsViewModel for a smooth refreshing * Update refreshable ScrollView to native for iOS 16+ (openedx#75) * Update refreshable ScrollView to native for iOS 16+ * Codestyle improvements (openedx#76) * codestyle improvements * remove unused code * ios 17 bugfixes (openedx#77) * bugfixes * Change license to Apache (openedx#78) --------- Co-authored-by: IvanStepanok <128456094+IvanStepanok@users.noreply.github.com>
IvanStepanok
pushed a commit
to raccoongang/openedx-app-ios
that referenced
this pull request
Sep 1, 2025
* fix: video tab with youtube (openedx#52) * fix: don't show error if only youtube videos * fix: call UI updates from main queue * fix: don't send completion at youtube video start --------- Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com> * chore: delete unneeded MainActor instructions * feat: save playback speed (openedx#67) * chore: save playback speed in CourseStorage * chore: add full screen for youtube on iPad * chore: save value in userdefaults * chore: little refactor * fix: fix warning * chore: added CourseStorage as injection * chore: moved playback speed to user settings --------- Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com> * chore: analytics screen events improvements and name fixes (openedx#76) * chore: fix tests --------- Co-authored-by: Anton Yarmolenko <37253+rnr@users.noreply.github.com> Co-authored-by: Saeed Bashir <sbashir@2u.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.