fix: bug in taxonomy import plan - #123
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @rpenido! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
| taxonomy.delete() | ||
| return Response(import_error, status=status.HTTP_400_BAD_REQUEST) | ||
| except ValueError as e: | ||
| taxonomy.delete() |
There was a problem hiding this comment.
@rpenido I think this issue was addressed by the recently-merged #122 -- it changed the import code to catch generic Exceptions, so we should never see the ValueError here.
We didn't tag a new release with that fix though, so will need to wait until a new release is tagged to run it with the platform.
40e41f4 to
1d418d6
Compare
rpenido
changed the title
1d418d6 to
3080ac3
Compare
|
@rpenido Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
|
Closed in favor of #126 |
3 participants
WIP