Skip to content

Fix minor asset storage admin issue [FC-0062] #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pomegranited merged 3 commits into from
Oct 25, 2024
Merged

Fix minor asset storage admin issue [FC-0062] #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53d3581
fix: wrap call to storage path in NotImplementedError
pomegranited Oct 24, 2024
6ac94d1
chore: bump version to 0.16.2
pomegranited Oct 25, 2024
16781fe
fix: log.warning instead of log.exception
pomegranited Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openedx_learning/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
Open edX Learning ("Learning Core").
"""

__version__ = "0.16.1"
__version__ = "0.16.2"
10 changes: 8 additions & 2 deletions openedx_learning/apps/authoring/contents/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from __future__ import annotations

from functools import cache, cached_property
from logging import getLogger

from django.conf import settings
from django.core.exceptions import ImproperlyConfigured, ValidationError
Expand All @@ -19,6 +20,8 @@
from ....lib.managers import WithRelationsManager
from ..publishing.models import LearningPackage

logger = getLogger()

__all__ = [
"MediaType",
"Content",
Expand Down Expand Up @@ -316,8 +319,11 @@ def os_path(self):

This will return ``None`` if there is no backing file (has_file=False).
"""
if self.has_file:
return get_storage().path(self.path)
try:
if self.has_file:
return get_storage().path(self.path)
except NotImplementedError:
logger.warning("Storage backend does not support path()")
return None

def read_file(self) -> File:
Expand Down