docs: adr for enabling producing to event bus via settings - #224
Merged
Conversation
|
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
timmc-edx
reviewed
May 24, 2023
timmc-edx
reviewed
May 25, 2023
navinkarkera
force-pushed
the
navin/configurable-handler-adr
branch
from
May 26, 2023 06:10
42568a5 to
ca804fc
Compare
tecoholic
reviewed
May 31, 2023
navinkarkera
force-pushed
the
navin/configurable-handler-adr
branch
from
May 31, 2023 09:55
ca804fc to
4db9565
Compare
tecoholic
approved these changes
May 31, 2023
tecoholic
left a comment
tecoholic
left a comment
There was a problem hiding this comment.
@navinkarkera 👍 LGTM
- I tested this: NA
- I read through the code
- I checked for accessibility issues
- Includes documentation
|
@mariajgrimaldi would you be able to review/merge this? |
robrap
reviewed
Jun 1, 2023
robrap
left a comment
robrap
left a comment
Contributor
There was a problem hiding this comment.
I'm excited about this change. Thanks for the ADR work.
robrap
self-requested a review
June 1, 2023 20:55
navinkarkera
force-pushed
the
navin/configurable-handler-adr
branch
from
June 5, 2023 06:48
4db9565 to
2f4dbed
Compare
robrap
reviewed
Jun 5, 2023
robrap
left a comment
robrap
left a comment
Contributor
There was a problem hiding this comment.
I'll have someone else join in on the discussion of where to define defaults. Thank you.
navinkarkera
force-pushed
the
navin/configurable-handler-adr
branch
from
June 6, 2023 05:33
b1d9611 to
fd624f9
Compare
9 tasks
timmc-edx
reviewed
Jun 6, 2023
Member
|
@mariajgrimaldi @mphilbrick211 @robrap Hi folks, would it be possible to get this merged soon? It will really help with the deployment of our project. |
Contributor
|
@sameenfatima78: Navin will need to speak to the timeline. At the same time, temporarily adding the hardcoded version with a feature flag shouldn’t be a big deal and will keep you unblocked. Let me know if you want to discuss further. |
robrap
approved these changes
Jun 9, 2023
timmc-edx
reviewed
Jun 9, 2023
mariajgrimaldi
approved these changes
Jun 13, 2023
mariajgrimaldi
left a comment
mariajgrimaldi
left a comment
Member
There was a problem hiding this comment.
I left a few tiny comments
navinkarkera
force-pushed
the
navin/configurable-handler-adr
branch
from
June 14, 2023 04:41
6bec8e9 to
0ef040a
Compare
This was referenced Jun 14, 2023
Merged
navinkarkera
force-pushed
the
navin/configurable-handler-adr
branch
from
June 23, 2023 09:41
0ef040a to
d96b3d1
Compare
timmc-edx
reviewed
Jun 23, 2023
timmc-edx
reviewed
Jun 23, 2023
navinkarkera
force-pushed
the
navin/configurable-handler-adr
branch
from
June 26, 2023 05:29
d96b3d1 to
17c7dd3
Compare
Contributor
Author
|
This is ready to be merged now. |
timmc-edx
approved these changes
Jun 26, 2023
|
@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: ADR for enabling producing to event bus via settings
ISSUE: #210
Merge checklist:
Post merge:
finished.